Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301613

Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions

Show all headers | View raw

2016-01-05 12:23 GMT-03:00 Joe Perches <joe@perches.com>:
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>
>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token)
>> > >>       return '/';
>> > >>  }
>> > >>
>> > >> -static void qh_lines(
>> > >> -     struct ehci_hcd *ehci,
>> > >> -     struct ehci_qh *qh,
>> > >> -     char **nextp,
>> > >> -     unsigned *sizep
>> > >> -)
>> > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh,
>> > >> +                     char **nextp, unsigned *sizep)
>> > >>  {
>> > >>       u32                     scratch;
>> > >>       u32                     hw_curr;
>> > >>
>> > >
>> > And about that style? Should be done?
>>
>> You mean squeezing the function parameters into two lines?  That's
>> okay.
Yes. I'll change this patch to do only that squeezing.

>>
>> However, the style in this file is to indent continuation lines by two
>> extra tab stops, not to line things up with an open paren on the first
>> line.
I see. I used 3 tabs, reducing to 2.

>
> It's not consistent.
> It's a bit of a mix of 1 and 2 tabs, and some others.
I noticed it. Maybe to avoid the 80th column there are 1 tab indentations.

>
>



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 09/17] usb: host: ehci-dbg: fix up function definitions "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 21:20 +0100
  Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Alan Stern <stern@rowland.harvard.edu> - 2016-01-04 22:10 +0100
    Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 00:30 +0100
      Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Alan Stern <stern@rowland.harvard.edu> - 2016-01-05 16:20 +0100
        Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Joe Perches <joe@perches.com> - 2016-01-05 16:30 +0100
          Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 16:30 +0100
            Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 16:40 +0100
          Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Alan Stern <stern@rowland.harvard.edu> - 2016-01-05 17:10 +0100
            Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Joe Perches <joe@perches.com> - 2016-01-05 17:20 +0100
              Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Alan Stern <stern@rowland.harvard.edu> - 2016-01-05 17:30 +0100
                Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 18:10 +0100
        Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Joe Perches <joe@perches.com> - 2016-01-05 16:30 +0100

csiph-web