Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300102
| Path | csiph.com!news.mixmin.net!weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/5] xen-netback: Delete an unnecessary goto statement in connect_rings() |
| Date | Sat, 02 Jan 2016 19:00:02 +0100 |
| Message-ID | <qMyD8-2In-23@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <qMyD7-2In-3@gated-at.bofh.it> |
| X-Original-To | xen-devel@lists.xenproject.org, netdev@vger.kernel.org, Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| X-Provags-ID | V03:K0:sOThxM3kN6ruz+XQLLjt1f//uR094S6+DAWmamy5phNc2nzV4Eg RLsa9qps1Z2sf6IyLZRX9AtGHqT4voBghCBgp0gFql/vx31nlvNlIaBExX1bzju9xsQ3tMh pOZRolxIPhiVx+JrjMWacUvLzqegeFu1+ZxiAz8of2aL7e2OtUsUfVRuoz41pSuZpyuHBzs hEmaAchll49SM4ytFXxkw== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:5iDKCvW9JsY=:EF1Cf/pCGqxMjWnln8B3np mPsTXQcPppEz/VapWWI4th8C3g+kxNgRiGMisz398kzkZgzOP7B8AhYg7Bj3uNMaIWTamwv2Z zb1mcCUJ12LnBic2sEVyYFuvchB/T3FoxFt1DIuVKjYLXbzxvxJWkceesmJAdy+afZVni+FqJ 9R2nHDMcu6qIBd19PNzI2DlXPW4GeRJEtxBYHknZ9L9gFrR0ekL/l2TOshnGbW4XKl5JV12Na 9i3XF3NcB8nRXpXzn2Kj8qB3Nn5+UXuFGXF/3n2jFiv2HOBrrHo93AwoiMaWaHlSbTslzEx2L BsUCh7hHIEkn/ecxFeuKFyfXwNsoRzrRRpqPIQyRJaeFIFeU2777S9Z8ZxSt3FO2mh+YBS2+i SPVxcIMqLhPIkRzz/abS8zT5kXwFXgZiK94V9MQe8YmYK4aBaUL6jtLMaT6UMu3ErruVodbN4 1y3ftzOXz0qXM9+kayktCSSiMi42IGpxQEmd8aMqiPekRTcSNeMK4+9lJ49gy5FK/co/Qfc6O hPzlRCfisbBOQMxJpl+O8V06OKaoqT2sRsVCP+xyDIPTQfRCrIZtauGRA8B+EOrhbK299VlRH KQ/eZmlv28gZpnkC5mBieo+NZB0L7e9uue5wF9+sCZwu3ILTH515GMKA4HEz0HUofl3JgTty3 MQy4kaYEFsek8OapBRqfCpGeXuuxmiC4BjGYrvf0tAnOsrgPqPENo5/Cwts30vRlvfOElLuja UBw+FopZvBVMKMFMWYXESWnnl5sxhuUvl2ptFPPJAfHee5I9efFxHqXxiJBGC6dCVTMwx/1HQ MQYQgCj |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr> |
| X-Original-Date | Sat, 2 Jan 2016 18:55:29 +0100 |
| X-Original-Message-ID | <56880F11.7030303@users.sourceforge.net> |
| X-Original-References | <566ABCD9.1060404@users.sourceforge.net> <56880DD4.2090806@users.sourceforge.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1300102 |
Show key headers only | View raw
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Jan 2016 17:50:21 +0100
One goto statement referred to a source code position directly behind it.
Thus omit such an unnecessary jump.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/xen-netback/xenbus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 7f2895d..d4947e1 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -933,13 +933,11 @@ static int connect_rings(struct backend_info *be, struct xenvif_queue *queue)
/* Map the shared frame, irq etc. */
err = xenvif_connect(queue, tx_ring_ref, rx_ring_ref,
tx_evtchn, rx_evtchn);
- if (err) {
+ if (err)
xenbus_dev_fatal(dev, err,
"mapping shared-frames %lu/%lu port tx %u rx %u",
tx_ring_ref, rx_ring_ref,
tx_evtchn, rx_evtchn);
- goto err;
- }
err: /* Regular return falls through with err == 0 */
kfree(xspath);
--
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] xen-netback: Fine-tuning for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 19:00 +0100 [PATCH 2/5] xen-netback: Delete an unnecessary goto statement in connect_rings() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 19:00 +0100 [PATCH 5/5] xen-netback: Delete an unnecessary variable initialisation in xen_register_watchers() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 19:10 +0100 Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations Joe Perches <joe@perches.com> - 2016-01-03 02:40 +0100 Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:50 +0100 Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations Wei Liu <wei.liu2@citrix.com> - 2016-01-04 12:10 +0100
csiph-web