Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)

From	Stephan Mueller <smueller@chronox.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)
Date	2016-01-02 10:30 +0100
Message-ID	<qMqFA-6j1-7@gated-at.bofh.it> (permalink)
References	<qL7lD-49U-5@gated-at.bofh.it> <qLfVT-19v-5@gated-at.bofh.it> <qMel4-74I-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Freitag, 1. Januar 2016, 21:12:40 schrieb Stephan Mueller:

Hi Herbert,

> Am Mittwoch, 30. Dezember 2015, 11:47:53 schrieb Herbert Xu:
> 
> Hi Herbert,
> 
> > On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote:
> > > Hello,
> > > 
> > > On commit 8513342170278468bac126640a5d2d12ffbff106
> > > + crypto: algif_skcipher - Use new skcipher interface
> > > + crypto: algif_skcipher - Require setkey before accept(2)
> > > + crypto: af_alg - Disallow bind/setkey/... after accept(2)
> > 
> > OK there is a silly bug in the last patch.  Here is an updated
> > version.
> 
> With this patch, the AF_ALG interface stops working. I tested the HMAC
> operation and I am unable to set the key with the following call:
> 
> ret = setsockopt(handle->tfmfd, SOL_ALG, ALG_SET_KEY, key, keylen);
> 
> This call returns EBUSY.

Please disregard my email. I did not update my library to the newly requested 
order of performing the setkey before the accept call. After the update of my 
library I can confirm that the modification works for all AF_ALG interfaces.

-- 
Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

crypto: deadlock in alg_setsockopt Dmitry Vyukov <dvyukov@google.com> - 2015-12-29 19:40 +0100
  [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2) Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-30 04:50 +0100
    Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2) Stephan Mueller <smueller@chronox.de> - 2016-01-01 21:20 +0100
      Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2) Stephan Mueller <smueller@chronox.de> - 2016-01-02 10:30 +0100

csiph-web