Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036

From	Xing Zheng <zhengxing@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036
Date	2016-01-02 03:40 +0100
Message-ID	<qMkgN-2c4-5@gated-at.bofh.it> (permalink)
References	<qKApH-79E-3@gated-at.bofh.it> <qKApH-79E-1@gated-at.bofh.it> <qLbyV-6Wl-5@gated-at.bofh.it> <qM7tg-2y5-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


OK, I think I will use named structures.

Thanks.

> 在 2016年1月1日，20:55，Arnd Bergmann <arnd@arndb.de> 写道：
> 
>> On Tuesday 29 December 2015 14:59:59 Florian Fainelli wrote:
>>> On December 27, 2015 11:22:20 PM PST, Xing Zheng <zhengxing@rock-chips.com> wrote:
>>> The RK3036's GRFs offset are different with RK3066/RK3188, and need to
>>> set
>>> mac TX/RX clock before probe emac.
>>> 
>>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>>> ---
>> <snip>
>>> };
>>> 
>>> static const struct of_device_id emac_rockchip_dt_ids[] = {
>>> -      { .compatible = "rockchip,rk3066-emac", .data =
>>> &emac_rockchip_dt_data[0] },
>>> -      { .compatible = "rockchip,rk3188-emac", .data =
>>> &emac_rockchip_dt_data[1] },
>>> +      { .compatible = "rockchip,rk3036-emac", .data =
>>> &emac_rockchip_dt_data[0] },
>>> +      { .compatible = "rockchip,rk3066-emac", .data =
>>> &emac_rockchip_dt_data[1] },
>>> +      { .compatible = "rockchip,rk3188-emac", .data =
>>> &emac_rockchip_dt_data[2] },
>>>      { /* Sentinel */ }
>> 
>> Food for thought, you might want to use an enum here to index emac_rockchip_dt_data which would be less error prone if you add/remove entries in this structure.
> 
> I would use named structures instead:
> 
> static const struct emac_rockchip_soc_data emac_rk3066_emac_data = {
>    .grf_offset = 0x154,
> };
> 
> static const struct of_device_id emac_rockchip_dt_ids[] = {
>    { .compatible = "rockchip,rk3066-emac", .data = &emac_rk3066_emac_data,
>    ...
> };
> 
>    Armd
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Xing Zheng <zhengxing@rock-chips.com> - 2015-12-28 08:30 +0100
  Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Florian Fainelli <f.fainelli@gmail.com> - 2015-12-30 00:10 +0100
    Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Heiko Stübner <heiko@sntech.de> - 2015-12-30 00:40 +0100
    Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Arnd Bergmann <arnd@arndb.de> - 2016-01-01 14:00 +0100
      Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Xing Zheng <zhengxing@rock-chips.com> - 2016-01-02 03:40 +0100

csiph-web