Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300371

[PATCH v2 5/5] Staging: panel: Make code more readable

Show all headers | View raw

Repace 'for' statement by strchr() function to make code more readable.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
v2: use strchr().
 drivers/staging/panel/panel.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index fcfcda7..1219ff7 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -2043,7 +2043,7 @@ static void init_scan_timer(void)
 static u8 input_name2mask(const char *name, __u64 *mask, __u64 *value,
 			  u8 *imask, u8 *omask)
 {
-	static char sigtab[10] = "EeSsPpAaBb";
+	const char sigtab[] = "EeSsPpAaBb";
 	u8 im, om;
 	__u64 m, v;
 
@@ -2053,13 +2053,13 @@ static u8 input_name2mask(const char *name, __u64 *mask, __u64 *value,
 	v = 0ULL;
 	while (*name) {
 		int in, out, bit, neg;
+		const char *idx;
 
-		for (in = 0; (in < sizeof(sigtab)) && (sigtab[in] != *name);
-		     in++)
-			;
-
-		if (in >= sizeof(sigtab))
+		idx = strchr(sigtab, *name);
+		if (!idx)
 			return 0;	/* input name not found */
+
+		in = idx - sigtab;
 		neg = (in & 1);	/* odd (lower) names are negated */
 		in >>= 1;
 		im |= BIT(in);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Staging: panel: TODO fixes Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-01-03 20:40 +0100
  [PATCH v2 5/5] Staging: panel: Make code more readable Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-01-03 20:50 +0100
  [PATCH  v2 4/5] Staging: panel: Reduce value range for *name Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-01-03 20:50 +0100
  [PATCH v2 3/5] Staging: panel: Remove ULL Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-01-03 20:50 +0100
  [PATCH v2 2/5] Staging: panel: Remove typedef pmask_t Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-01-03 20:50 +0100
  [PATCH v2 1/5] Staging: panel: Use u8 type Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-01-03 20:50 +0100

csiph-web