Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional
Date	2016-01-03 19:40 +0100
Message-ID	<qMVJn-zf-17@gated-at.bofh.it> (permalink)
References	<qAwdI-3Lg-23@gated-at.bofh.it> <qAwdI-3Lg-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Nov 30, 2015 at 01:55:19PM +0100, Linus Walleij wrote:
> On Fri, Nov 20, 2015 at 10:45 PM, Li Yang <leoli@freescale.com> wrote:
> 
> > -       if (IS_ERR(i2c_imx->pinctrl)) {
> > +       /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
> > +       if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
> > +                       PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
> 
> This is one of the evils of deferred probe: you never know if
> something will eventually turn up. It feels wrong to bail out
> on deferred probe...
> 
> I have no better idea though.
> Acked-by

Linus, proper ack next time please, so patchwork will pick it up
automatically.

Li Yang: There have been some other changes to the imx driver. Could you
rebase against my for-next or for-4.5 and add Linus' ack? Thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional Wolfram Sang <wsa@the-dreams.de> - 2016-01-03 19:40 +0100

csiph-web