Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300295

Re: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_set_timer()

Show all headers | View raw

On Sun, 3 Jan 2016, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 3 Jan 2016 09:19:32 +0100
> 
> Pass a value directly in a call of the function "regmap_update_bits"
> instead of an extra initialisation for one local variable at the beginning.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/rtc/rtc-ab-b5ze-s3.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c
> index 88f1d0b..fed52d0 100644
> --- a/drivers/rtc/rtc-ab-b5ze-s3.c
> +++ b/drivers/rtc/rtc-ab-b5ze-s3.c
> @@ -561,7 +561,6 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm,
>  {
>  	struct abb5zes3_rtc_data *data = dev_get_drvdata(dev);
>  	u8 regs[ABB5ZES3_TIMA_SEC_LEN];
> -	u8 mask = ABB5ZES3_REG_TIM_CLK_TAC0 | ABB5ZES3_REG_TIM_CLK_TAC1;
>  	int ret;
>  
>  	/* Program given number of seconds to Timer A registers */
> @@ -575,7 +574,9 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm,
>  
>  	/* Configure Timer A as a watchdog timer */
>  	ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK,
> -				 mask, ABB5ZES3_REG_TIM_CLK_TAC1);
> +				 ABB5ZES3_REG_TIM_CLK_TAC0
> +				 | ABB5ZES3_REG_TIM_CLK_TAC1,
> +				 ABB5ZES3_REG_TIM_CLK_TAC1);

This doesn't seem like an improvement.  The concept (mask) has 
disappeared, the binary operation is strangely broken, and the function 
call has one more line of arguments, which all look sort of the same and 
thus are hard to understand.

Don't underestimate the value of naming things.

julia

>  	if (ret)
>  		dev_err(dev, "%s: failed to update timer\n", __func__);
>  
> -- 
> 2.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] rtc-ab-b5ze-s3: Fine-tuning for some function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 09:50 +0100
  [PATCH 3/8] rtc-ab-b5ze-s3: Delete an unnecessary variable  initialisation in _abb5zes3_rtc_set_timer() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
  [PATCH 5/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an  assignment in _abb5zes3_rtc_read_alarm() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
  [PATCH 2/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  abb5zes3_rtc_set_alarm() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
  [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_interrupt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
    Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_interrupt() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-03 13:50 +0100
      Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_interrupt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 18:10 +0100
    Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_interrupt() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-03 13:50 +0100
      Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_interrupt() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-03 18:00 +0100
      Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_interrupt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 18:00 +0100
  [PATCH 4/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an  assignment in _abb5zes3_rtc_set_alarm() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
  [PATCH 1/8] rtc-ab-b5ze-s3: Better exception handling in  abb5zes3_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
  [PATCH 6/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_read_timer() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
  [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_set_timer() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 10:00 +0100
    Re: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_set_timer() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-03 13:50 +0100
      Re: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_set_timer() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-03 18:30 +0100
      Re: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in  _abb5zes3_rtc_set_timer() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 18:30 +0100

csiph-web