Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300267
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() |
| Date | 2016-01-03 08:40 +0100 |
| Message-ID | <qMLqG-2pY-3@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <qMBrk-4rN-3@gated-at.bofh.it> <qMBrk-4rN-5@gated-at.bofh.it> <qME5Q-6aU-7@gated-at.bofh.it> <qMKXE-2eY-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, 2016-01-03 at 08:00 +0100, SF Markus Elfring wrote: > > > r = 0; > > > - > > > -err: > > > +free_reply: > > > kfree(reply); > > > +free_cmd: > > > kfree(cmd); > > > - > > > > Why are you deleting the two blank lines here? > > Can they be unnecessary at this source code place > according to the Linux coding style convention? As far as I know, there's no linux specific accepted convention for blank lines preceding labels. My personal preference is for a blank line before a new block, but not before the second and subsequent labels in an error handling block. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] NFC-mei_phy: Fine-tuning for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 22:00 +0100
[PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 22:00 +0100
Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() Julian Calaby <julian.calaby@gmail.com> - 2016-01-03 00:50 +0100
Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 08:10 +0100
Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() Joe Perches <joe@perches.com> - 2016-01-03 08:40 +0100
[PATCH 2/3] NFC-mei_phy: Refactoring for mei_nfc_if_version() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 22:00 +0100
csiph-web