Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted_filename

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted_filename
Date	2016-01-03 06:00 +0100
Message-ID	<qMIVQ-HN-11@gated-at.bofh.it> (permalink)
References	<qMAvg-3Tb-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 02, 2016 at 08:50:11PM +0100, Arnd Bergmann wrote:
> gcc correctly warns that the ctx variable in ext4_set_encrypted_filename
> has gone out of scope in ext4_set_encrypted_filename if we enter the
> retry path and a 'goto' into the previous code block can not guarantee
> to get the contents back:
> 
> fs/ext4/namei.c: In function 'ext4_set_encrypted_filename':
> fs/ext4/namei.c:4035:10: warning: 'ctx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    retval = ext4_xattr_set_handle(handle, inode,

Sorry, this was a known bug that I fixed about a week ago, but I
hadn't pushed out an update to the ext4 dev branch because I hadn't
had a chance to finish testing the project quota changes.  I've just
pushed out an update.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: disable retry logic in ext4_set_encrypted_filename Arnd Bergmann <arnd@arndb.de> - 2016-01-02 21:00 +0100
  Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted_filename Theodore Ts'o <tytso@mit.edu> - 2016-01-03 06:00 +0100

csiph-web