Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1300163

[PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid"

From Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid"
Date 2016-01-03 02:30 +0100
Message-ID <qMFEC-7c8-13@gated-at.bofh.it> (permalink)
References <qMFEC-7c8-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Original issue is fixed by:

  f2fs: cover more area with nat_tree_lock

This reverts commit 24928634f81b1592e83b37dcd89ed45c28f12feb.
---
 fs/f2fs/node.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 4dab09f..6d5f548 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1602,8 +1602,6 @@ retry:
 
 	/* We should not use stale free nids created by build_free_nids */
 	if (nm_i->fcnt && !on_build_free_nids(nm_i)) {
-		struct node_info ni;
-
 		f2fs_bug_on(sbi, list_empty(&nm_i->free_nid_list));
 		list_for_each_entry(i, &nm_i->free_nid_list, list)
 			if (i->state == NID_NEW)
@@ -1614,13 +1612,6 @@ retry:
 		i->state = NID_ALLOC;
 		nm_i->fcnt--;
 		spin_unlock(&nm_i->free_nid_list_lock);
-
-		/* check nid is allocated already */
-		get_node_info(sbi, *nid, &ni);
-		if (ni.blk_addr != NULL_ADDR) {
-			alloc_nid_done(sbi, *nid);
-			goto retry;
-		}
 		return true;
 	}
 	spin_unlock(&nm_i->free_nid_list_lock);
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] f2fs: check the page status filled from disk Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-03 02:30 +0100
  [PATCH 2/3] f2fs: cover more area with nat_tree_lock Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-03 02:30 +0100
    RE: [f2fs-dev] [PATCH 2/3] f2fs: cover more area with nat_tree_lock Chao Yu <chao2.yu@samsung.com> - 2016-01-05 10:40 +0100
      Re: [f2fs-dev] [PATCH 2/3] f2fs: cover more area with nat_tree_lock Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-05 19:00 +0100
        RE: [f2fs-dev] [PATCH 2/3] f2fs: cover more area with nat_tree_lock Chao Yu <chao2.yu@samsung.com> - 2016-01-06 05:00 +0100
  [PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid" Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-03 02:30 +0100
  RE: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from disk Chao Yu <chao2.yu@samsung.com> - 2016-01-05 10:40 +0100
    Re: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from  disk Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-05 18:50 +0100
      RE: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from disk Chao Yu <chao2.yu@samsung.com> - 2016-01-06 02:30 +0100
        Re: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from  disk Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-06 03:40 +0100
  Re: [PATCH 1/3 v2] f2fs: check the page status filled from disk Jaegeuk Kim <jaegeuk@kernel.org> - 2016-01-06 05:20 +0100
    RE: [f2fs-dev] [PATCH 1/3 v2] f2fs: check the page status filled from  disk Chao Yu <chao2.yu@samsung.com> - 2016-01-06 06:30 +0100

csiph-web