Re: [PATCH v4 0/3] Add AMBA bus probing support to ACPI

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/3] Add AMBA bus probing support to ACPI
Date	2016-01-03 01:10 +0100
Message-ID	<qMEpb-6wz-1@gated-at.bofh.it> (permalink)
References	<qISAq-2iG-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, December 23, 2015 05:19:39 PM Aleksey Makarov wrote:
> As discussed when Shannon Zhao sent a patch to add platform_device support
> to pl061 driver. Russel and other maintainers prefered that ACPI learned
> how to create AMBA devices rather than converting/adding platform_device
> support to AMBA drivers.
> 
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/431364
> 
> 1) Adds basic AMBA device probing support to ACPI, it uses a whitelist of
> device IDs as the number of AMBA devices is limited. Currently the two ids
> present are those used in QEMU for arm64.
> 
> 2) Adds the plumbing into ACPI probe sequence.
> 
> 3) From ACPI pl011 is only defined (SBSA document) to be in SBSA mode which has
> reduced functionality. There may be a better method to do this that I have
> overlooked.
> 
> v4:
> - A memory leak has been fixed (Vladimir Zapolskiy)
> - ACPI_COMPANION() -> has_acpi_companion() (Andy Shevchenko)
> - pr_err() -> dev_err() (Andy Shevchenko)
> - The call to amba_register_dummy_clk() has been moved to to acpi_amba_init()
>   (Vladimir Zapolskiy)
> - Return value has been fixed (Vladimir Zapolskiy)
> 
> v3:
> https://lkml.kernel.org/g/1450716100-13688-1-git-send-email-aleksey.makarov@linaro.org
> - Compilation without CONFIG_ARM_AMBA has been fixed
> 
> v2:
> https://lkml.kernel.org/g/1450709399-7246-1-git-send-email-aleksey.makarov@linaro.org
> - A new ACPI scan handler for AMBA devices has been implemented
> - The order of `if` branches in amba-pl011.c has been changed
> - A couple of `static`s have been added
> - The compilation of the acpi_amba.c unit has made conditional
> - A comment on SBSA UART has been added
> 
> v1:
> https://lkml.kernel.org/g/1443609530-21524-1-git-send-email-graeme.gregory@linaro.org
> 
> Graeme Gregory (3):
>   ACPI: amba bus probing support
>   ACPI: scan add in amba probing
>   serial: amba-pl011: add ACPI support to AMBA probe

The ACPI part looks OK to me, but I'd really like to know whether or not the
ARM maintainers like this series too.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] Add AMBA bus probing support to ACPI Aleksey Makarov <aleksey.makarov@linaro.org> - 2015-12-23 15:30 +0100
  [PATCH v4 2/3] ACPI: scan add in amba probing Aleksey Makarov <aleksey.makarov@linaro.org> - 2015-12-23 15:30 +0100
  [PATCH v4 1/3] ACPI: amba bus probing support Aleksey Makarov <aleksey.makarov@linaro.org> - 2015-12-23 15:30 +0100
    Re: [PATCH v4 1/3] ACPI: amba bus probing support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-23 20:00 +0100
    Re: [PATCH v4 1/3] ACPI: amba bus probing support Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-03 14:40 +0100
  Re: [PATCH v4 0/3] Add AMBA bus probing support to ACPI "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-03 01:10 +0100

csiph-web