Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300128
| From | Bjørn Mork <bjorn@mork.no> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() |
| Date | 2016-01-02 22:40 +0100 |
| Message-ID | <qMC41-4VJ-5@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <qMbdv-4Vr-3@gated-at.bofh.it> <qMbdw-4Vr-17@gated-at.bofh.it> |
| Organization | m |
SF Markus Elfring <elfring@users.sourceforge.net> writes: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 1 Jan 2016 17:32:07 +0100 > > Reduce the scope for the local variable "desc" to one branch > of an if statement. This patch is harmless. But is also pointless. You could at least try to explain why this must be changed. I'm not interested in why you think it is better this way - I might agree with that. what I am interested in is the advantage changing the code gives us. Some analysis of the risk and work involved would also be nice. Is this change really worth it? Personally I am convinced that I wasted any time I used writing this, and you wasted any time you used reading it. Sorry. Note: This patch would have been fine if it was a natural part of some *improvement* of the driver, i.e. a bugfix or feaure addition. As a standalone patch I see it as noise. Please stop the noise and start writing something useful. I'm sure you can fix bugs instead. Wouldn't that be more interesting? More challenging? These mindless robotic code refactoring patches are really best left for robots. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] net-qmi_wwan: Fine-tuning for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-01 18:00 +0100
[PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-01 18:00 +0100
Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() Bjørn Mork <bjorn@mork.no> - 2016-01-02 22:40 +0100
[PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-01 18:00 +0100
Re: [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() Bjørn Mork <bjorn@mork.no> - 2016-01-02 22:40 +0100
Re: [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() David Miller <davem@davemloft.net> - 2016-01-03 02:50 +0100
csiph-web