Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1299932

[PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select
Date 2016-01-01 15:50 +0100
Message-ID <qM9bH-3FN-1@gated-at.bofh.it> (permalink)
References <qM8z1-3sD-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The hdlcd driver has no build-time dependency on the SCPI clock
and the bogus 'select' causes a warning when SCPI is disabled:

warning: (DRM_HDLCD) selects COMMON_CLK_SCPI which has unmet direct dependencies (COMMON_CLK && (ARM_SCPI_PROTOCOL || COMPILE_TEST))

This removes the select statement.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found two more bugs in the same driver, so this is now a patch series

diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 2f4d3b7fb871..81ea7802ca50 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -9,7 +9,6 @@ config DRM_HDLCD
 	tristate "ARM HDLCD"
 	depends on DRM_ARM
 	depends on COMMON_CLK
-	select COMMON_CLK_SCPI
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
 	help

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm: arm-hdlcd: remove DMA_CMA select Arnd Bergmann <arnd@arndb.de> - 2016-01-01 15:10 +0100
  [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select Arnd Bergmann <arnd@arndb.de> - 2016-01-01 15:50 +0100
    Re: [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select Thierry Reding <thierry.reding@gmail.com> - 2016-01-04 09:30 +0100
  [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Arnd Bergmann <arnd@arndb.de> - 2016-01-01 15:50 +0100
    Re: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Thierry Reding <thierry.reding@gmail.com> - 2016-01-04 09:30 +0100
  [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-01 23:10 +0100
    Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Thierry Reding <thierry.reding@gmail.com> - 2016-01-04 09:30 +0100
      Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-04 09:50 +0100
        Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Liviu Dudau <liviu.dudau@arm.com> - 2016-01-11 12:20 +0100
          Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-11 13:20 +0100
            Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Liviu Dudau <liviu.dudau@arm.com> - 2016-01-11 13:30 +0100
              Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-11 15:10 +0100
                Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Liviu Dudau <liviu.dudau@arm.com> - 2016-01-11 15:20 +0100
  Re: [PATCH] drm: arm-hdlcd: remove DMA_CMA select Thierry Reding <thierry.reding@gmail.com> - 2016-01-04 09:30 +0100
  Re: [PATCH] drm: arm-hdlcd: remove DMA_CMA select Liviu Dudau <liviu.dudau@arm.com> - 2016-01-11 11:40 +0100

csiph-web