Re: CGroup Namespaces (v8)

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: CGroup Namespaces (v8)
Date	2016-01-01 10:50 +0100
Message-ID	<qM4vo-w4-9@gated-at.bofh.it> (permalink)
References	<qIJdM-4TG-5@gated-at.bofh.it> <qM3fY-7Nk-5@gated-at.bofh.it> <qM3IZ-87K-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 1, 2016 at 12:59 AM, Serge E. Hallyn
<serge.hallyn@ubuntu.com> wrote:
> On Fri, Jan 01, 2016 at 12:19:44AM -0800, Dan Williams wrote:
>> On Tue, Dec 22, 2015 at 8:23 PM,  <serge.hallyn@ubuntu.com> wrote:
>> > Hi,
>> >
>> > following is a revised set of the CGroup Namespace patchset which Aditya
>> > Kali has previously sent.  The code can also be found in the cgroupns.v8
>> > branch of
>> >
>> > https://git.kernel.org/cgit/linux/kernel/git/sergeh/linux-security.git/
>>
>> Happy New Year!
>>
>> I'm hitting both a build and boot regression in -next with these
>> patches.  The bisect log reports:
>>
>> git bisect skip f176ae3a5df610e0373c39538cc7744c7788b3df
>> # bad: [54b39d263704b66cc8006ce8f7dd4743fdabae70] cgroup: cgroup
>> namespace setns support
>> git bisect bad 54b39d263704b66cc8006ce8f7dd4743fdabae70
>> # good: [bf9b3590879afbaa54148d817ed68a0b51180375] sched: new clone
>> flag CLONE_NEWCGROUP for c
>> group namespace
>> git bisect good bf9b3590879afbaa54148d817ed68a0b51180375
>> # only skipped commits left to test
>> # possible first bad commit:
>> [54b39d263704b66cc8006ce8f7dd4743fdabae70] cgroup: cgroup namespa
>> ce setns support
>> # possible first bad commit:
>> [f176ae3a5df610e0373c39538cc7744c7788b3df] cgroup: introduce cgro
>> up namespaces
>>
>> Where compiling "f176ae3a5df6"  fails with:
>>
>> kernel/cgroup.c: In function ‘cgroupns_put’:
>> kernel/cgroup.c:5956:2: error: implicit declaration of function
>> ‘to_cg_ns’ [-Werror=implicit-f
>> unction-declaration]
>>  put_cgroup_ns(to_cg_ns(ns));
>
> Hi,
>
> is it possible you have a bad tree?

No, I don't believe so...

>  Looking at
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/kernel/cgroup.c?id=refs/tags/next-20151231
> to_cg_ns should definately be defined there.
>

Right, but it's not defined until commit 54b39d263704 "cgroup: cgroup
namespace setns support", however it is first used in the preceeding
commit f176ae3a5df6 "cgroup: introduce cgroup namespaces".  The bad
patch ordering breaks bisection.

Commit 54b39d263704 "cgroup: cgroup namespace setns support" not
booting is a separate issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

CGroup Namespaces (v8) serge.hallyn@ubuntu.com - 2015-12-23 05:30 +0100
  [PATCH 7/8] cgroup: Add documentation for cgroup namespaces serge.hallyn@ubuntu.com - 2015-12-23 05:30 +0100
    Re: [PATCH 7/8] cgroup: Add documentation for cgroup namespaces Tejun Heo <tj@kernel.org> - 2015-12-28 18:50 +0100
      Re: [PATCH 7/8] cgroup: Add documentation for cgroup namespaces Serge Hallyn <serge@hallyn.com> - 2015-12-28 22:20 +0100
        [PATCH] cgroup: Add documentation for cgroup namespaces Tejun Heo <tj@kernel.org> - 2015-12-28 22:50 +0100
  [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn@ubuntu.com - 2015-12-23 05:30 +0100
    Re: [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-12-31 14:50 +0100
      Re: [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2016-01-01 02:00 +0100
        Re: [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-01-01 02:20 +0100
        Re: [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2016-01-01 03:00 +0100
  [PATCH 1/8] kernfs: Add API to generate relative kernfs path serge.hallyn@ubuntu.com - 2015-12-23 05:30 +0100
    Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Tejun Heo <tj@kernel.org> - 2015-12-23 17:10 +0100
      Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-23 17:40 +0100
      Re: [PATCH 1/8 v8.2] kernfs: Add API to generate relative kernfs path "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-23 20:40 +0100
    Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Tejun Heo <tj@kernel.org> - 2015-12-23 17:30 +0100
      Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Greg KH <gregkh@linuxfoundation.org> - 2015-12-23 18:00 +0100
  Re: CGroup Namespaces (v8) Tejun Heo <tj@kernel.org> - 2015-12-28 18:50 +0100
  Re: CGroup Namespaces (v8) Dan Williams <dan.j.williams@intel.com> - 2016-01-01 09:30 +0100
    Re: CGroup Namespaces (v8) "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2016-01-01 10:00 +0100
      Re: CGroup Namespaces (v8) Dan Williams <dan.j.williams@intel.com> - 2016-01-01 10:50 +0100
        Re: CGroup Namespaces (v8) "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2016-01-01 19:10 +0100
          Re: CGroup Namespaces (v8) Dan Williams <dan.j.williams@intel.com> - 2016-01-01 20:20 +0100
            Re: CGroup Namespaces (v8) Tejun Heo <tj@kernel.org> - 2016-01-02 13:00 +0100

csiph-web