Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299429

Re: [PATCH] BTRFS: Runs the xor function if a Block has failed

Show all headers | View raw

On Wed, Dec 30, 2015 at 01:28:36AM -0500, Sanidhya Solanki wrote:
> The patch adds the xor function after the P stripe
> has failed, without bad data or the Q stripe.

That's just the comment copied, the changelog does not explain why it's
ok to do just the run_xor there. It does not seem trivial to me. Please
describe that the end result after the code change is expected.

> @@ -1864,8 +1864,8 @@ static void __raid_recover_end_io(struct btrfs_raid_bio *rbio)
>  					/*
>  					 * Just the P stripe has failed, without
>  					 * a bad data or Q stripe.
> -					 * TODO, we should redo the xor here.
>  					 */
> +					run_xor(pointers, rbio->nr_data - 1, PAGE_CACHE_SIZE);
>  					err = -EIO;
>  					goto cleanup;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] BTRFS: Runs the xor function if a Block has failed Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-30 11:40 +0100
  Re: [PATCH] BTRFS: Runs the xor function if a Block has failed David Sterba <dsterba@suse.cz> - 2015-12-30 18:30 +0100
    Re: [PATCH] BTRFS: Runs the xor function if a Block has failed Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-31 07:20 +0100

csiph-web