Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

From	Heinrich Schuchardt <xypron.glpk@gmx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
Date	2015-12-30 12:20 +0100
Message-ID	<qLmXo-5SI-19@gated-at.bofh.it> (permalink)
References	<qLaWe-6tJ-7@gated-at.bofh.it> <qLmE2-5wj-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote:
> Hi Heinrich,
> 
> On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote:
>> IOCTL SIOCRTMSG does nothing but return EINVAL.
>>
>> So comment it as unused.
> 
> Can you say something about how you confirmed this?
> It's not immediately obvious from the code.
> 
> Cheers,
> 
> Michael

grep -GHrn SIOCRTMSG

SIOCRTMSG is only used in:
* net/ipv4/af_inet.c
* include/uapi/linux/sockios.h

inet_ioctl calls ip_rt_ioctl.

ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
otherwise.

cf.
http://lkml.iu.edu/hypermail/linux/kernel/0911.0/02636.html

Best regards

Heinrich

> 
> 
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>  include/uapi/linux/sockios.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
>> index e888b1a..8e7890b 100644
>> --- a/include/uapi/linux/sockios.h
>> +++ b/include/uapi/linux/sockios.h
>> @@ -27,7 +27,7 @@
>>  /* Routing table calls. */
>>  #define SIOCADDRT	0x890B		/* add routing table entry	*/
>>  #define SIOCDELRT	0x890C		/* delete routing table entry	*/
>> -#define SIOCRTMSG	0x890D		/* call to routing system	*/
>> +#define SIOCRTMSG	0x890D		/* unused			*/
>>  
>>  /* Socket configuration controls. */
>>  #define SIOCGIFNAME	0x8910		/* get iface name		*/
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused Heinrich Schuchardt <xypron.glpk@gmx.de> - 2015-12-29 23:30 +0100
  Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2015-12-30 12:00 +0100
    Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused Heinrich Schuchardt <xypron.glpk@gmx.de> - 2015-12-30 12:20 +0100

csiph-web