Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

From	Ksenija Stanojević <ksenija.stanojevic@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters
Date	2015-12-30 11:20 +0100
Message-ID	<qLm1k-5j3-21@gated-at.bofh.it> (permalink)
References	<qKhwK-6ac-5@gated-at.bofh.it> <qKhwK-6ac-9@gated-at.bofh.it> <qLhbj-24O-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
>> Split comment in order to fit into 80 characters per line.
>> Found by checkpatch.pl
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> ---
>
> Instead of multiline maybe this is better:
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 79ac192..3525919 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
>                 lcd_send_serial(0x5F);  /* R/W=W, RS=1 */
>                 lcd_send_serial(' ' & 0x0F);
>                 lcd_send_serial((' ' >> 4) & 0x0F);
> -               usleep_range(40, 100);  /* the shortest data takes at least 40 us */
> +               /* the shortest data takes at least 40 us */
> +               usleep_range(40, 100);
>         }
>         spin_unlock_irq(&pprt_lock);

It's already been done by Bijosh Thykkoottathil:
https://lkml.org/lkml/2015/12/18/681

Regards,
Ksenija
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] Staging: panel: Fix checkpatch warnings Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2015-12-27 12:20 +0100
  [PATCH 2/2] Staging: panel: Remove space Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2015-12-27 12:20 +0100
  [PATCH 1/2] Staging: panel: Fix line over 80 characters Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2015-12-27 12:20 +0100
    Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-30 06:10 +0100
      Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters Ksenija Stanojević <ksenija.stanojevic@gmail.com> - 2015-12-30 11:20 +0100
        Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-30 12:40 +0100

csiph-web