Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299272

Re: [PATCH 1/4] soc: mediatek: Separate scpsys driver common code

Show all headers | View raw

On Wednesday 30 December 2015 14:41:43 James Liao wrote:
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index 0a4ea80..eca6fb7 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -22,11 +22,20 @@ config MTK_PMIC_WRAP
>  
>  config MTK_SCPSYS
>         bool "MediaTek SCPSYS Support"
> -       depends on ARCH_MEDIATEK || COMPILE_TEST
> -       default ARM64 && ARCH_MEDIATEK
>         select REGMAP
>         select MTK_INFRACFG
>         select PM_GENERIC_DOMAINS if PM
>         help
>           Say yes here to add support for the MediaTek SCPSYS power domain
>           driver.
> +
> +config MTK_SCPSYS_MT8173
> +       bool "MediaTek MT8173 SCPSYS Support"
> +       depends on ARCH_MEDIATEK || COMPILE_TEST
> +       select MTK_SCPSYS
> +       default ARCH_MEDIATEK
> 

Please don't "select" a user-visible Kconfig symbol. Either hide MTK_SCPSYS
by removing the string behind 'bool', or make this "depends on MTK_SCPSYS".

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] soc: mediatek: Separate scpsys driver common code James Liao <jamesjj.liao@mediatek.com> - 2015-12-30 07:50 +0100
  Re: [PATCH 1/4] soc: mediatek: Separate scpsys driver common code Arnd Bergmann <arnd@arndb.de> - 2015-12-30 10:00 +0100
    Re: [PATCH 1/4] soc: mediatek: Separate scpsys driver common code James Liao <jamesjj.liao@mediatek.com> - 2015-12-30 11:10 +0100

csiph-web