Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check

From	"Gang He" <ghe@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check
Date	2015-12-30 07:20 +0100
Message-ID	<qLih4-2TJ-1@gated-at.bofh.it> (permalink)
References	<qJuPn-vt-3@gated-at.bofh.it> <qJuPn-vt-1@gated-at.bofh.it> <qLa9P-5VQ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Andrew,


>>> 
> On Fri, 25 Dec 2015 15:16:16 +0800 Gang He <ghe@suse.com> wrote:
> 
>> Export ocfs2_kset object from ocfs2_stackglue kernel module,
>> then online file check code will create the related sysfiles
>> under ocfs2_kset object.
>> 
>> ...
>>
>> --- a/fs/ocfs2/stackglue.c
>> +++ b/fs/ocfs2/stackglue.c
>> @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = {
>>  	.attrs = ocfs2_attrs,
>>  };
>>  
>> -static struct kset *ocfs2_kset;
>> +struct kset *ocfs2_kset;
>> +EXPORT_SYMBOL_GPL(ocfs2_kset);
> 
> The EXPORT_SYMBOL is only needed if this symbol is to be referred to
> from a different module.  That isn't the case here - everything which
> refers to ocfs2_kset is linked into ocfs2.ko, correct?
There are some kernel modules (Not single KO file) for OCFS2 file system, the variable ocfs2_kset is located in ocfs2_stackglue.ko kernel module,
if the main kernel module ocfs2.ko wants to refer to this variable, it looks to have to export this symbol? 

Thanks
Gang  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Gang He <ghe@suse.com> - 2015-12-25 08:20 +0100
  Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Andrew Morton <akpm@linux-foundation.org> - 2015-12-29 22:40 +0100
    Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file  check "Gang He" <ghe@suse.com> - 2015-12-30 07:20 +0100

csiph-web