Re: Inconsistent description in memory-barrier.txt

From	Jianyu Zhan <nasa4836@gmail.com>
Newsgroups	linux.kernel
Subject	Re: Inconsistent description in memory-barrier.txt
Date	2015-12-30 03:30 +0100
Message-ID	<qLeGt-ml-3@gated-at.bofh.it> (permalink)
References	<qIoCm-i1-1@gated-at.bofh.it> <qLcOl-7E2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 8:26 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> It looks like you are quite correct, good catch!  Does the patch below
> fix this?
>
>                                                         Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit add179813efa2ba8a4afd29828d3335cf346d2a8
> Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Date:   Tue Dec 29 16:23:18 2015 -0800
>
>     documentation: Fix control dependency and identical stores
>
>     The summary of the "CONTROL DEPENDENCIES" section incorrectly states that
>     barrier() may be used to prevent compiler reordering when more than one
>     leg of the control-dependent "if" statement start with identical stores.
>     This is incorrect at high optimization levels.  This commit therefore
>     updates the summary to match the detailed description.
>
>     Reported by: Jianyu Zhan <nasa4836@gmail.com>
>     Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> index 85304ebd187c..50190368400c 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -800,9 +800,13 @@ In summary:
>        use smp_rmb(), smp_wmb(), or, in the case of prior stores and
>        later loads, smp_mb().
>
> -  (*) If both legs of the "if" statement begin with identical stores
> -      to the same variable, a barrier() statement is required at the
> -      beginning of each leg of the "if" statement.
> +  (*) If both legs of the "if" statement begin with identical stores to
> +      the same variable, then those stores must be ordered, either by
> +      preceding both of them with smp_mb() or by using smp_store_release()
> +      to carry out the stores.  Please note that it is -not- sufficient
> +      to use barrier() at beginning of each leg of the "if" statement,
> +      as optimizing compilers do not necessarily respect barrier()
> +      in this case.
>
>    (*) Control dependencies require at least one run-time conditional
>        between the prior load and the subsequent store, and this


Yep. It looks good to me.  Concise, precise wording, as always.


Thanks,
Jianyu Zhan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Inconsistent description in memory-barrier.txt Jianyu Zhan <nasa4836@gmail.com> - 2015-12-22 07:30 +0100
  Re: Inconsistent description in memory-barrier.txt "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-12-30 01:30 +0100
    Re: Inconsistent description in memory-barrier.txt Jianyu Zhan <nasa4836@gmail.com> - 2015-12-30 03:30 +0100

csiph-web