Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299199

Re: [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read callback

Show all headers | View raw

On Wed, Dec 30, 2015 at 08:42:01AM +0800, Lu Baolu wrote:
> In current acm driver, the bulk-in callback function ignores the
> URBs unlinked in usb core.
> 
> This causes unexpected data loss in some cases. For example,
> runtime suspend entry will unlinked all urbs and set urb->status
> to -ENOENT even those urbs might have data not processed yet.
> Hence, data loss occurs.
> 
> This patch lets bulk-in callback function handle unlinked urbs
> to avoid data loss.
> 
> Signed-off-by: Tang Jian Qiang <jianqiang.tang@intel.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Cc: stable@vger.kernel.org
> Acked-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/usb/class/cdc-acm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

What changed in v2?

Please always document that below the --- line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read callback Lu Baolu <baolu.lu@linux.intel.com> - 2015-12-30 01:50 +0100
  Re: [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read  callback Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-30 02:50 +0100
    Re: [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read  callback Lu Baolu <baolu.lu@linux.intel.com> - 2015-12-30 06:10 +0100

csiph-web