Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates.

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates.
Date	2015-12-29 23:20 +0100
Message-ID	<qLaMy-6qF-15@gated-at.bofh.it> (permalink)
References	<qG7mi-2sQ-15@gated-at.bofh.it> <qHh9V-6J4-31@gated-at.bofh.it> <qIYw9-5TK-13@gated-at.bofh.it> <qJnNT-4Be-1@gated-at.bofh.it> <qKOM2-8uu-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+Arnd and Olof

On Mon, Dec 28, 2015 at 4:39 PM, Michael Turquette
<mturquette@baylibre.com> wrote:
> Quoting Eric Anholt (2015-12-24 15:45:15)
>> Michael Turquette <mturquette@baylibre.com> writes:
>>
>> > On Fri, Dec 18, 2015 at 8:19 PM, Rob Herring <robh@kernel.org> wrote:
>> >> On Tue, Dec 15, 2015 at 03:35:57PM -0800, Eric Anholt wrote:
>> >>> These will be used for enabling UART1, SPI1, and SPI2.
>> >>>
>> >>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> >>> ---
>> >>>
>> >>> v2: Make the binding cover both the IRQ and clock enable registers.
>> >>>
>> >>>  .../bindings/clock/brcm,bcm2835-aux-clock.txt      | 31 ++++++++++++++++++++++
>> >>>  include/dt-bindings/clock/bcm2835-aux.h            | 17 ++++++++++++
>> >>>  2 files changed, 48 insertions(+)
>> >>>  create mode 100644 Documentation/devicetree/bindings/clock/brcm,bcm2835-aux-clock.txt
>> >>>  create mode 100644 include/dt-bindings/clock/bcm2835-aux.h
>> >>
>> >> Acked-by: Rob Herring <robh@kernel.org>
>> >
>> > Applied to clk-next.
>> >
>> > Next time if you put the header into the clk driver patch then we can
>> > send the binding description through the DT tree and take the header
>> > and C file through the clk tree in one patch.
>>
>> I would *love* to do that, but I've previously been told that having the
>> bindings patch reference a header file not present as of the bindings
>> patch is not acceptable and made to change it.
>
> Ugh, that is annoying. I would think that having code compile properly
> would trump the desire to have all of the documentation merged as one
> patch.

What about compiling the dts?

> On the other hand, I've been asked to not take binding descriptions
> through the clk tree. That is a policy that I'm happy to comply with,
> but it is at odds with the recommendation for the header and the binding
> description to be merged together.

By who? Any bindings in a series I always expect the subsystem
maintainers to take the whole series. That doesn't solve the problem
though as there is still a dependency between a subsystem tree and
arm-soc typically.

> DT folks, what is the right way to do this? An immutable, shared branch
> just for a single header file solves the problem, but also feels very
> cumbersome for such a trivial issue.

Arnd and Olof have been complaining about this problem which is worse
when it is a binding, driver and dts.

I'm open to maintaining a branch for this purpose if that helps. That
or staggering merging of bindings and drivers/dts are the only ideas
I've come up with.

> How about allowing binding descriptions to be merged without the header
> file, so long as it is merged through another tree?

I think that is wrong if we have the goal to separate bindings from
the kernel and the bindings should stand on their own. However, if it
greatly simplifies things, i'd be okay with that.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates. Eric Anholt <eric@anholt.net> - 2015-12-16 00:40 +0100
  [PATCH v2 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree. Eric Anholt <eric@anholt.net> - 2015-12-16 00:40 +0100
    Re: [PATCH v2 3/3] ARM: bcm2835: Add the auxiliary clocks to the  device tree. Stefan Wahren <stefan.wahren@i2se.com> - 2015-12-16 11:40 +0100
  [PATCH v2 2/3] clk: bcm2835: Add a driver for the auxiliary peripheral clock gates. Eric Anholt <eric@anholt.net> - 2015-12-16 00:40 +0100
    Re: [PATCH v2 2/3] clk: bcm2835: Add a driver for the auxiliary  peripheral clock gates. Michael Turquette <mturquette@baylibre.com> - 2015-12-23 21:50 +0100
  Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary  peripheral clock gates. Rob Herring <robh@kernel.org> - 2015-12-19 05:20 +0100
    Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary  peripheral clock gates. Michael Turquette <mturquette@baylibre.com> - 2015-12-23 21:50 +0100
      Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates. Eric Anholt <eric@anholt.net> - 2015-12-25 00:50 +0100
        Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral  clock gates. Michael Turquette <mturquette@baylibre.com> - 2015-12-28 23:50 +0100
          Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary  peripheral clock gates. Rob Herring <robh@kernel.org> - 2015-12-29 23:20 +0100
            Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates. Arnd Bergmann <arnd@arndb.de> - 2015-12-30 10:40 +0100
              Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral  clock gates. Michael Turquette <mturquette@baylibre.com> - 2015-12-31 01:20 +0100

csiph-web