Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier

Path	csiph.com!news.mixmin.net!weretis.net!feeder1.news.weretis.net!news.roellig-ltd.de!open-news-network.org!border2.nntp.ams1.giganews.com!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	James Liao <jamesjj.liao@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier
Date	Thu, 31 Dec 2015 07:10:02 +0100
Message-ID	<qLEAW-LM-5@gated-at.bofh.it> (permalink)
References	<qLiK5-33r-5@gated-at.bofh.it> <qLkLU-4kl-3@gated-at.bofh.it> <qLm1k-5j3-13@gated-at.bofh.it> <qLmkG-5pC-17@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
X-Listener-Flag	11101
Content-Type	text/plain; charset="us-ascii"
X-Mailer	Evolution 3.2.3-0ubuntu6
Content-Transfer-Encoding	7bit
MIME-Version	1.0
X-Mtk	N
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <srv_heupstream@mediatek.com>, Kevin Hilman <khilman@kernel.org>, <linux-kernel@vger.kernel.org>, Daniel Kurtz <djkurtz@chromium.org>, <linux-mediatek@lists.infradead.org>, Sascha Hauer <kernel@pengutronix.de>, Matthias Brugger <matthias.bgg@gmail.com>
X-Original-Date	Thu, 31 Dec 2015 13:59:26 +0800
X-Original-Message-ID	<1451541566.10610.10.camel@mtksdaap41>
X-Original-References	<1451457706-14798-1-git-send-email-jamesjj.liao@mediatek.com> <1670989.QknqqsXE3p@wuerfel> <1451470328.22426.5.camel@mtksdaap41> <6145950.8rtkDup7QD@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1299586

Show key headers only | View raw

Hi Arnd,

On Wed, 2015-12-30 at 11:35 +0100, Arnd Bergmann wrote:
> On Wednesday 30 December 2015 18:12:08 James Liao wrote:
> > On Wed, 2015-12-30 at 09:52 +0100, Arnd Bergmann wrote:
> > > On Wednesday 30 December 2015 14:41:44 James Liao wrote:
> > > > Some power domain comsumers may init before module_init.
> > > > So the power domain provider (scpsys) need to be initialized
> > > > earlier too.
> > > > 
> > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> > > > ---
> > > > 
> > > 
> > > Why?
> > 
> > Some drivers use different init level to ensure they can be initialized
> > before other drivers. To support these drivers, moving scpsys driver's
> > initial function to subsys_init is the most easy way.
> 
> This is just the same generic explanation that you already have.
> 
> Please be more specific what the dependency is and why we can't rely
> on deferred probing here.

In our case, there is a SMI driver provide APIs to control multiple
devices that attached to different power domains.Video encoder / decoder
and GPU drivers are SMI users. It's not easy for SMI users to detect SMI
and scpsys driver are initialized or not. A most easy way to resolve the
init sequence issue is moving SMI and scpsys driver in early init stage.

Do you prefer to keep scpsys driver's init in module_init? If yes, I can
remove this patch in next version.


Best regards,

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier James Liao <jamesjj.liao@mediatek.com> - 2015-12-30 07:50 +0100
  Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier Arnd Bergmann <arnd@arndb.de> - 2015-12-30 10:00 +0100
    Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier James Liao <jamesjj.liao@mediatek.com> - 2015-12-30 11:20 +0100
      Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier Arnd Bergmann <arnd@arndb.de> - 2015-12-30 11:40 +0100
        Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier James Liao <jamesjj.liao@mediatek.com> - 2015-12-31 07:10 +0100
          Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier James Liao <jamesjj.liao@mediatek.com> - 2015-12-31 10:20 +0100
            Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier Arnd Bergmann <arnd@arndb.de> - 2015-12-31 15:50 +0100
              Re: [PATCH 2/4] soc: mediatek: Init MT8173 scpsys driver earlier James Liao <jamesjj.liao@mediatek.com> - 2016-01-04 05:30 +0100

csiph-web