Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree

From	Bob Liu <bob.liu@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree
Date	2015-12-31 04:30 +0100
Message-ID	<qLC66-7kV-3@gated-at.bofh.it> (permalink)
References	<qIXqq-5hs-13@gated-at.bofh.it> <qIXA6-5kL-21@gated-at.bofh.it> <qLjZv-42K-3@gated-at.bofh.it> <qLvHj-2WR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/31/2015 04:39 AM, Dan Williams wrote:
> On Wed, Dec 30, 2015 at 12:02 AM, Bob Liu <bob.liu@oracle.com> wrote:
>> Hi Ross,
>>
>> On 12/24/2015 03:39 AM, Ross Zwisler wrote:
>>> Add support for tracking dirty DAX entries in the struct address_space
>>> radix tree.  This tree is already used for dirty page writeback, and it
>>> already supports the use of exceptional (non struct page*) entries.
>>>
>>> In order to properly track dirty DAX pages we will insert new exceptional
>>> entries into the radix tree that represent dirty DAX PTE or PMD pages.
>>
>> I may get it wrong, but there is "struct page" for persistent memory after
>> "[PATCH v4 00/18]get_user_pages() for dax pte and pmd mappings".
>> So why not just add "struct page" to radix tree directly just like normal page cache?
>>
>> Then we don't need to deal with any exceptional entries and special writeback.
> 
> That "struct page" is optional and fsync/msync needs to operate in its absence.
> 

Any special reason or scenario that "struct page" should not be enabled?
I didn't see any disadvantages if always enable "struct page" by force when using DAX model for pmem.
The benefits would be things can be more simple and less potential bugs because of smaller patches.

Happy New Year!
Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v6 0/7] DAX fsync/msync support Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:40 +0100
  [PATCH v6 6/7] ext4: call dax_pfn_mkwrite() for DAX fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:50 +0100
  [PATCH v6 5/7] ext2: call dax_pfn_mkwrite() for DAX fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:50 +0100
  [PATCH v6 7/7] xfs: call dax_pfn_mkwrite() for DAX fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:50 +0100
  [PATCH v6 3/7] mm: add find_get_entries_tag() Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:50 +0100
    RE: [PATCH v6 3/7] mm: add find_get_entries_tag() "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2015-12-24 01:30 +0100
  [PATCH v6 2/7] dax: support dirty DAX entries in radix tree Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:50 +0100
    Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree Bob Liu <bob.liu@oracle.com> - 2015-12-30 09:10 +0100
      Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree Dan Williams <dan.j.williams@intel.com> - 2015-12-30 21:40 +0100
        Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree Bob Liu <bob.liu@oracle.com> - 2015-12-31 04:30 +0100
          Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree Dan Williams <dan.j.williams@intel.com> - 2015-12-31 23:10 +0100
    Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree Jan Kara <jack@suse.cz> - 2016-01-05 10:50 +0100
  [PATCH v6 4/7] dax: add support for fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 20:50 +0100
    Re: [PATCH v6 4/7] dax: add support for fsync/msync Dan Williams <dan.j.williams@intel.com> - 2016-01-03 19:20 +0100
      Re: [PATCH v6 4/7] dax: add support for fsync/msync Jan Kara <jack@suse.cz> - 2016-01-05 12:20 +0100
        Re: [PATCH v6 4/7] dax: add support for fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-01-05 17:00 +0100
      Re: [PATCH v6 4/7] dax: add support for fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-01-06 19:20 +0100
    Re: [PATCH v6 4/7] dax: add support for fsync/msync Jan Kara <jack@suse.cz> - 2016-01-05 12:20 +0100
      Re: [PATCH v6 4/7] dax: add support for fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-01-05 18:20 +0100
        Re: [PATCH v6 4/7] dax: add support for fsync/msync Dan Williams <dan.j.williams@intel.com> - 2016-01-05 18:30 +0100
          Re: [PATCH v6 4/7] dax: add support for fsync/msync Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-01-05 19:20 +0100
            Re: [PATCH v6 4/7] dax: add support for fsync/msync Dan Williams <dan.j.williams@intel.com> - 2016-01-05 19:30 +0100

csiph-web