Re: [PATCH] regmap: flat: introduce register striding to savesomememories

From	Xiubo Li <lixiubo@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regmap: flat: introduce register striding to savesomememories
Date	2015-12-31 02:40 +0100
Message-ID	<qLAnE-68n-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <qFFzJ-Ts-19@gated-at.bofh.it> <qGYAi-3aB-11@gated-at.bofh.it> <qGYAi-3aB-9@gated-at.bofh.it> <qLtcu-1he-3@gated-at.bofh.it> <qLtcu-1he-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 31/12/2015 01:58, Mark Brown wrote:
> On Fri, Dec 18, 2015 at 04:59:38PM +0800, lixiubo@cmss.chinamobile.com wrote:
>
>>> I think we'll need to continue supporting non power of two strides so
>>> an unconditional conversion to shifts might be an issue - some weird DSP
>>> probably does that.
>
>> Yes, agreed.
>
>> IMO this won't happen to MMIO, and for the device using MMIO the
>> register strides should equal to power of two.
>
>> Are there some cases I have met?
>
> DSPs exposed via I2C and SPI are the main things I'm worried about.
> It's fairly common for DSPs to have unusual word sizes including things
> like three bytes.
>

Yes, if so, for this case the non power of two strides should be still 
supported.

Thanks for your promotion, and I will think over of this carefully.

BRs

Xiubo Li




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regmap: flat: introduce register striding to save some memories Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-14 08:20 +0100
  Re: [PATCH] regmap: flat: introduce register striding to save some  memories Mark Brown <broonie@kernel.org> - 2015-12-14 19:00 +0100
    Re: [PATCH] regmap: flat: introduce register striding to save  somememories Mark Brown <broonie@kernel.org> - 2015-12-18 09:30 +0100
      Re: Re: [PATCH] regmap: flat: introduce register striding to save  somememories Mark Brown <broonie@kernel.org> - 2015-12-30 19:00 +0100
        Re: [PATCH] regmap: flat: introduce register striding to savesomememories Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-31 02:40 +0100

csiph-web