Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1299116

Re: timerfd_settime/timerfd_gettime issue ?

From Helge Deller <deller@gmx.de>
Newsgroups linux.kernel
Subject Re: timerfd_settime/timerfd_gettime issue ?
Date 2015-12-29 21:20 +0100
Message-ID <qL8Uq-5fn-1@gated-at.bofh.it> (permalink)
References <qJW8W-Qh-3@gated-at.bofh.it> <qKZ4L-76v-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 29.12.2015 10:44, Thomas Gleixner wrote:
> On Sat, 26 Dec 2015, Helge Deller wrote:
>> I see a strange behavior on the parisc platform, for which I'm not sure if
>> it's intended or if there is a bug somewhere.
> 
>> The program calls timerfd_settime() and sets a timer (e.g. sec=0, nsec=100000000).
>> Directly after setting the timer it calls timerfd_gettime() and receives
>> (sec=0, nsec=103914413).
>> The second nsec is higher than the initial nsec value which was set.
>>
>> Does timerfd_settime() maybe tries to add the initial time it takes to start
>> the timer?
>>
>> Any idea or hint?
> 
> Yes. This is a fallout from the power aware batching magic. Interesting that
> nobody noticed this within 7 years.
> 
> Does the patch below fix your issue?

No, the patch below doesn't help.

I still see:
[  644.916000] timerfd_settime: interval (sec=0, nsec=100000000) it_value (sec=0, nsec=100000000) 
[  645.024000] timerfd_gettime: interval (sec=0, nsec=100000000) it_value (sec=0, nsec=103029949) 

Helge


> diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
> index 76dd4f0da5ca..0f4a3e8734f1 100644
> --- a/include/linux/hrtimer.h
> +++ b/include/linux/hrtimer.h
> @@ -268,7 +268,7 @@ static inline s64 hrtimer_get_expires_ns(const struct hrtimer *timer)
>  
>  static inline ktime_t hrtimer_expires_remaining(const struct hrtimer *timer)
>  {
> -	return ktime_sub(timer->node.expires, timer->base->get_time());
> +	return ktime_sub(timer->_softexpires, timer->base->get_time());
>  }
>  
>  static inline ktime_t hrtimer_cb_get_time(struct hrtimer *timer)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

timerfd_settime/timerfd_gettime issue ? Helge Deller <deller@gmx.de> - 2015-12-26 13:30 +0100
  Re: timerfd_settime/timerfd_gettime issue ? Thomas Gleixner <tglx@linutronix.de> - 2015-12-29 10:50 +0100
    Re: timerfd_settime/timerfd_gettime issue ? Helge Deller <deller@gmx.de> - 2015-12-29 21:20 +0100
      Re: timerfd_settime/timerfd_gettime issue ? Thomas Gleixner <tglx@linutronix.de> - 2015-12-30 11:00 +0100

csiph-web