Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1299084
| From | Insu Yun <wuninsu@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] cx231xx: correctly handling failed allocation |
| Date | 2015-12-29 20:00 +0100 |
| Message-ID | <qL7EZ-4gU-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Since kmalloc can be failed in memory pressure, if not properly handled, NULL dereference can be happend Signed-off-by: Insu Yun <wuninsu@gmail.com> --- drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index 47a98a2..9725e4f 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1382,6 +1382,8 @@ static int cx231xx_bulk_copy(struct cx231xx *dev, struct urb *urb) buffer_size = urb->actual_length; buffer = kmalloc(buffer_size, GFP_ATOMIC); + if (!buffer) + return -ENOMEM; memcpy(buffer, dma_q->ps_head, 3); memcpy(buffer+3, p_buffer, buffer_size-3); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] cx231xx: correctly handling failed allocation Insu Yun <wuninsu@gmail.com> - 2015-12-29 20:00 +0100 Re: [PATCH] cx231xx: correctly handling failed allocation Devin Heitmueller <dheitmueller@kernellabs.com> - 2015-12-29 20:10 +0100
csiph-web