Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1299066

Re: [PATCH 02/10] spi: cadence, zynq: use to_platform_device()

Path csiph.com!au2pb.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Moritz Fischer <moritz.fischer@ettus.com>
Newsgroups linux.kernel
Subject Re: [PATCH 02/10] spi: cadence, zynq: use to_platform_device()
Date Tue, 29 Dec 2015 19:10:02 +0100
Message-ID <qL6SC-405-19@gated-at.bofh.it> (permalink)
References <qKjoR-7uf-5@gated-at.bofh.it> <qKjoS-7uf-15@gated-at.bofh.it>
X-Original-To Geliang Tang <geliangtang@163.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=ettus-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=B7+yzjavPIGiDg/kYpoUiwLWX0D4j5+5WZIP9jonX0s=; b=JgVdbRKjiftrHpgxb/g00kXUcSIXNB1eGTFz1nz2u9vKZE9T4cONDiCWBOsQFqimRz HT4LbRVW8vsNlmIvX1YjRLFExbYKd+HDHzpXYwnV7BOWloWrzLg5pcqUCzckhPPf+1bG JnSizxvpFcjrqZ0VRXooUYSHfQldYxQTlL5/FEF8IgSWMomvJD/kiCCO/TyXF3OtQQoX 36w7VSx/P1EB4eCWoz8LChzNtoUwtzM6Fld03QJnp3ijVd6Gvx9iv9W3ZL6Z8H+dnhJE GonrhCg32Ck7A360FfbUJHXgABUf6rbPQZhVaFVzZ8k0LWxtQznqFBMpUiDoszaINOzF X1GQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=B7+yzjavPIGiDg/kYpoUiwLWX0D4j5+5WZIP9jonX0s=; b=OV9QLL7YRdt7XgAAUQidP9H2J0jCPFrnDHIuUK1APCJTklwUF4caiHUaq9KzMTX9Kz ZSMHLc2a5B0rF/IdE3XU39JIEC0gUx7f0saAQh9hb1ckWWPqRV848EUOpVURvaMBXW2Z PohiHk0StoRY6iuCOq+2e+GNlb/3XNOJseLQOEwC3g4NfUdzNmkx5r9dmFk9Z0IasAHG 1YFlcfo/d8N3flJgScG+AS23MODP/z1RQoTbMZhV4IxLm8nFBk1lHPedmfUyZ4LqDHNv Rb7Y/7/HrBg+yNrGoZDGvFb2gv1IJ1jfTEZ2ax37iC7SF9HJpv8W1fa8Q/jkaj9ADJSv ilBA==
X-Gm-Message-State ALoCoQmI4eJYolJdqrdeelg+5PNZxwEnNyEsyLBvCBNk8WSiailMTBI9c0gjIJWFRW82gIYMwtoAIyvCAJasu9H9Zf4gSgNWHUeXn+qfXhxbsgUZ/G+QlyA=
MIME-Version 1.0
X-Received by 10.194.114.1 with SMTP id jc1mr64958208wjb.78.1451412064770; Tue, 29 Dec 2015 10:01:04 -0800 (PST)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 18
Organization linux.* mail to news gateway
X-Original-Cc Mark Brown <broonie@kernel.org>, Michal Simek <michal.simek@xilinx.com>, Sören Brinkmann <soren.brinkmann@xilinx.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-spi@vger.kernel.org
X-Original-Date Tue, 29 Dec 2015 10:01:04 -0800
X-Original-Message-ID <CAAtXAHd_Xp4WbXMSY5QVLT7cYnpbzObf5UHCnuzh64LgOBER3Q@mail.gmail.com>
X-Original-References <a554e6af3a3528c2206c94dab62b7800f96caa4b.1451221174.git.geliangtang@163.com> <522ef92bb1d83c651cbdd12ff10b594b2e2a691c.1451221174.git.geliangtang@163.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1299066

Show key headers only | View raw


Hi,

On Sun, Dec 27, 2015 at 5:15 AM, Geliang Tang <geliangtang@163.com> wrote:
> Use to_platform_device() instead of open-coding it.
>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Looks good to me, maybe (nit) split it up into two commits.

Cheers,

Moritz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 01/10] PM / devfreq: exynos: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
  [PATCH 02/10] spi: cadence, zynq: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
    Re: [PATCH 02/10] spi: cadence, zynq: use to_platform_device() Moritz Fischer <moritz.fischer@ettus.com> - 2015-12-29 19:10 +0100
      [PATCH 1/2] spi: cadence: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-30 16:00 +0100
        Re: [PATCH 1/2] spi: cadence: use to_platform_device() Mark Brown <broonie@kernel.org> - 2015-12-30 18:10 +0100
  [PATCH 03/10] dmaengine: ppc4xx: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
  [PATCH 08/10] staging: fbtft: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
  [PATCH 06/10] net: hns: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
    Re: [PATCH 06/10] net: hns: use to_platform_device() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-27 14:30 +0100
      Re: [PATCH 06/10] net: hns: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-28 03:50 +0100
    Re: [PATCH 06/10] net: hns: use to_platform_device() David Miller <davem@davemloft.net> - 2015-12-29 21:50 +0100
  [PATCH 07/10] platform/chrome: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
  [PATCH 10/10] ARM: plat-samsung: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
    Re: [PATCH 10/10] ARM: plat-samsung: use to_platform_device() Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-28 03:50 +0100
  [PATCH 05/10] mmc: cb710: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100
    Re: [PATCH 05/10] mmc: cb710: use to_platform_device() Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-28 14:30 +0100
  [PATCH 04/10] i2c: st: use to_platform_device() Geliang Tang <geliangtang@163.com> - 2015-12-27 14:20 +0100

csiph-web