Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299008

Re: [PATCH v1 2/3] ARM64 LPC: LPC driver implementation

Show all headers | View raw

在 2015/12/29 21:51, Arnd Bergmann 写道:
> On Tuesday 29 December 2015 21:33:51 Rongrong Zou wrote:
>> We only implement io cycles here, we hook the lpc_io_write_byte
>> and lpc_io_read_byte to inb/outb. So the drivers(ipmi/uart) which access
>> the legacy ISA I/O port need no modification.
>>
>> The low pin count specification is at
>> http://www.intel.com/design/chipsets/industry/lpc.htm
>>
>> Signed-off-by: Rongrong Zou <zourongrong@gmail.com>
>
> I'm slightly confused here: I thought this driver was hisilicon specific.
> Is the MMIO register layout that is used in this hardware actually standardized
> in a way that the driver also works for all other implementations?

The register defined is not standardized. other vendors may define their own
registers.

>
>> +
>> +static struct lpc_dev *lpc_dev;
>> +
>> +int lpc_master_write(unsigned int slv_access_mode, unsigned int cycle_type,
>> +		      unsigned int addr, unsigned char *buf, unsigned int len)
>> +{
>
> Please make all function definitions 'static' so we don't accidentally get
> other users that bypass the proper interface.
>
> 	Arnd
> _______________________________________________
> linuxarm mailing list
> linuxarm@huawei.com
> http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] ARM64 LPC: legacy ISA I/O support  Rongrong Zou <zourongrong@gmail.com> - 2015-12-29 14:40 +0100
  [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Rongrong Zou <zourongrong@gmail.com> - 2015-12-29 14:40 +0100
    Re: [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Arnd Bergmann <arnd@arndb.de> - 2015-12-29 15:00 +0100
      Re: [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Rongrong Zou <zourongrong@huawei.com> - 2015-12-29 15:10 +0100
        Re: [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Arnd Bergmann <arnd@arndb.de> - 2015-12-29 15:20 +0100
  [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou <zourongrong@gmail.com> - 2015-12-29 14:40 +0100
    Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Arnd Bergmann <arnd@arndb.de> - 2015-12-29 14:50 +0100
      Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou <zourongrong@huawei.com> - 2015-12-29 15:30 +0100
        Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Arnd Bergmann <arnd@arndb.de> - 2015-12-29 15:40 +0100
          Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou <zourongrong@huawei.com> - 2015-12-30 02:40 +0100
            Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Arnd Bergmann <arnd@arndb.de> - 2015-12-30 10:00 +0100
              Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou <zourongrong@huawei.com> - 2015-12-30 10:40 +0100
                Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Arnd Bergmann <arnd@arndb.de> - 2015-12-30 10:50 +0100
  [PATCH v1 3/3] ARM64 LPC: update binding doc Rongrong Zou <zourongrong@gmail.com> - 2015-12-29 14:40 +0100
    Re: [PATCH v1 3/3] ARM64 LPC: update binding doc Arnd Bergmann <arnd@arndb.de> - 2015-12-29 15:00 +0100
    Re: [PATCH v1 3/3] ARM64 LPC: update binding doc Arnd Bergmann <arnd@arndb.de> - 2015-12-30 10:10 +0100
      Re: [PATCH v1 3/3] ARM64 LPC: update binding doc Rongrong Zou <zourongrong@huawei.com> - 2015-12-31 15:20 +0100
        Re: [PATCH v1 3/3] ARM64 LPC: update binding doc Arnd Bergmann <arnd@arndb.de> - 2015-12-31 15:50 +0100

csiph-web