Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298998

Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko

Show all headers | View raw

On Tue, Dec 29, 2015 at 2:15 PM, Sebastian Frias <sf84@laposte.net> wrote:
> Hi,
>
> We are wondering what is the recommended way of adding support for a
> framebuffer driver on the Linux kernel.
> Below you can find a patch with a proposed solution.

That's not really a solution to add a driver to the kernel. You'd have
to include some actual driver code as well.


> Our frambuffer driver source code is provided separately, but right now it
> requires "cfb_fillrect", "cfb_copyarea" and "cfb_imageblit" to be provided
> by the kernel.
>
> Our current kernel fork (based on 3.4) hardcodes FB_CFB_FILLRECT,
> FB_CFB_COPYAREA and FB_CFB_IMAGEBLIT to yes.
> Since we are in the process of migrating to 4.x and upstreaming changes
> along the way, we would like to know if the patch below is the way to go
> with it or if you have suggestions to improve it.

Is the below patch really a patch you intend to upstream, or are you
just wondering about what your Kconfig entry should look like when you
upstream your driver?


> Subject: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko
>
> Signed-off-by: Sebastian Frias <sf84@laposte.net>
> ---
>  drivers/video/fbdev/Kconfig |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index e6d16d6..46c4ab2 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -615,6 +615,16 @@ config FB_BF537_LQ035
>           To compile this driver as a module, choose M here: the
>           module will be called bf537-lq035.
>
> +config FB_TANGO
> +       bool "Sigma Designs FrameBuffer support"
> +       depends on FB && ARCH_TANGO
> +       select FB_CFB_FILLRECT
> +       select FB_CFB_COPYAREA
> +       select FB_CFB_IMAGEBLIT
> +       help
> +         You need to enable this if you intend to use Sigma
> +         Designs' smp8xxxfb.ko driver.
> +
>  config FB_BFIN_7393
>         tristate "Blackfin ADV7393 Video encoder"
>         depends on FB && BLACKFIN

Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Sebastian Frias <sf84@laposte.net> - 2015-12-29 14:20 +0100
  Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Frans Klaver <fransklaver@gmail.com> - 2015-12-29 14:50 +0100
    Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Sebastian Frias <sf84@laposte.net> - 2015-12-29 15:10 +0100
      Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Frans Klaver <fransklaver@gmail.com> - 2015-12-29 15:20 +0100
        Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Sebastian Frias <sf84@laposte.net> - 2015-12-29 18:00 +0100
          Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-12-30 09:10 +0100
            Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Sebastian Frias <sf84@laposte.net> - 2015-12-30 10:40 +0100
              Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-12-30 11:40 +0100

csiph-web