Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core

From	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core
Date	2015-12-29 12:10 +0100
Message-ID	<qL0ka-824-23@gated-at.bofh.it> (permalink)
References	<qIWXo-57D-35@gated-at.bofh.it> <qJfQl-8ob-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 24, 2015 at 06:15:14PM +0300, Sergei Ianovich wrote:
> pxa2xx-uart was a separate uart platform driver. It was declaring
> the same device names and numbers as 8250 driver. As a result,
> it was impossible to use 8250 driver on PXA SoCs.
> 
> Upon closer examination pxa2xx-uart turned out to be a clone of
> 8250_core driver.
> 
> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
> Specification Update (April 19, 2010) is dropped. 8250_core reads
> from FIFO immediately after checking DR bit in LSR.
> 
> The patch leaves the original SERIAL_PXA driver around. The original
> driver is just marked DEPRECATED in Kconfig and C source. When
> the original driver is considered safe to remove, no changes
> to SERIAL_8250 will be necessary.
> 
> Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
> SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
> and the original drivers are made mutually exclusive.
> 
> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v5] serial: rewrite pxa2xx-uart to use 8250_core Sergei Ianovich <ynvich@gmail.com> - 2015-12-23 20:10 +0100
  Re: [PATCH v5] serial: rewrite pxa2xx-uart to use 8250_core kbuild test robot <lkp@intel.com> - 2015-12-24 10:20 +0100
  [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core Sergei Ianovich <ynvich@gmail.com> - 2015-12-24 16:20 +0100
    Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-29 12:10 +0100
      Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-29 18:00 +0100

csiph-web