Re: [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary
Date	2015-12-29 12:00 +0100
Message-ID	<qL0at-7IT-7@gated-at.bofh.it> (permalink)
References	<qIRO1-1P2-1@gated-at.bofh.it> <qIRO2-1P2-21@gated-at.bofh.it> <qKY8F-6qw-7@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Tue, 2015-12-29 at 10:40 +0200, Heikki Krogerus wrote:
> Hi Andy,
> 
> Found a bug from my code..
> 
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 0b22c8a..6c04d18 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -218,7 +218,7 @@ bool fwnode_property_present(struct
> > fwnode_handle *fwnode, const char *propname)
> >  	bool ret;
> >  
> >  	ret = __fwnode_property_present(fwnode, propname);
> > -	if (ret == false && fwnode->secondary)
> > +	if (ret == false && fwnode && fwnode->secondary)
> >  		ret = __fwnode_property_present(fwnode->secondary, 
> > propname);
> >  	return ret;
> >  }
> > @@ -423,7 +423,7 @@
> > EXPORT_SYMBOL_GPL(device_property_match_string);
> >  	int _ret_;							
> > 		\
> >  	_ret_ = FWNODE_PROP_READ(_fwnode_, _propname_, _type_,
> > _proptype_,		\
> >  				 _val_, _nval_);			
> > 		\
> > -	if (_ret_ == -EINVAL && _fwnode_->secondary)		
> > 			\
> > +	if (_ret_ == -EINVAL && fwnode && _fwnode_->secondary)	
> > 			\
> 
> This should be .._fwnode_ && _fwnode_->secondary)

Yeah, we compiled it correctly due to fwnode presents in all
occurrences of this macro.

I will fix and resend a new version.

> 
> >  		_ret_ = FWNODE_PROP_READ(_fwnode_->secondary,
> > _propname_, _type_,	\
> >  				_proptype_, _val_, _nval_);	
> > 			\
> >  	_ret_;							
> > 			\
> 
> 
> Cheers,
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] device property: post merge fixes Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-23 14:40 +0100
  [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING macro Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-23 14:40 +0100
    Re: [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING macro "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-28 03:50 +0100
      Re: [PATCH v2 1/3] device property: add spaces to  PROPERTY_ENTRY_STRING macro Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-28 12:30 +0100
        Re: [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING macro "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-30 02:20 +0100
          Re: [PATCH v2 1/3] device property: add spaces to  PROPERTY_ENTRY_STRING macro Andrew Morton <akpm@linux-foundation.org> - 2015-12-30 02:30 +0100
            Re: [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING macro "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-30 02:40 +0100
              Re: [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING  macro Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-30 02:50 +0100
              Re: [PATCH v2 1/3] device property: add spaces to  PROPERTY_ENTRY_STRING macro Andrew Morton <akpm@linux-foundation.org> - 2015-12-30 02:50 +0100
                Re: [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING macro "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-01 01:30 +0100
          Re: [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING  macro Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-30 02:40 +0100
  [PATCH v2 3/3] device property: avoid allocations of 0 length Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-23 14:40 +0100
  [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-23 14:40 +0100
    Re: [PATCH v2 2/3] device property: the secondary fwnode needs to  depend on the primary Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-12-29 09:50 +0100
      Re: [PATCH v2 2/3] device property: the secondary fwnode needs to  depend on the primary Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-29 12:00 +0100

csiph-web