ideapad_laptop: Fix for backlight regression

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Paul Buonopane <paul@earth2me.com>
Newsgroups	linux.kernel
Subject	ideapad_laptop: Fix for backlight regression
Date	Sun, 27 Dec 2015 10:30:01 +0100
Message-ID	<qKfOh-52f-11@gated-at.bofh.it> (permalink)
X-Original-To	linux-kernel@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=earth2me.com; s=google; h=to:from:subject:message-id:date:user-agent:mime-version :content-type:content-transfer-encoding; bh=wMTFgRwZ6G6GFnEWVmsN2NWMv9fRnzUiev3T6TqLCTk=; b=PexWZYJFGMBwnbPXUB6fI6/nrqVt5VfxR0VSQC71LxVvSWIgdN741n9KyJ1q1Ah6kR 9E4rH8mfd1EDlQGkM7bIgLs/hri96A4p+vkClkLwu9E9Np+yOYlPvfNnzE0fR3fgaT9u IdxgmPcqNEF+zzVh69Sduu3BiMEOt0Uy48s0k=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=wMTFgRwZ6G6GFnEWVmsN2NWMv9fRnzUiev3T6TqLCTk=; b=g9wFHi+d4AOArNyUEHVaYngl6G3hQwuwNx2+DwXGDYu8sckqEm6NYH2OneXo0b8KjG hZag9kUbOJAcDHjXc1JsDwNqEvVNGDRpTH4IBENZ6xAq+xYG/gbtvqmkksWHs+YqbQu2 aNoM2HhQ5Yi72xmJaARAVLv69FC5ATSYDMkgJW8FdxENceHX8YJ6WuwVaDp/O6yigN8R jthEK3KCqkq8hq9K90zINsENNREBfYFtDB1ZgA2J0Ek/l1jllcIoKUvqrWj6GoDtEWk1 EmOzO99ixZ+32lgnOuY1Hj/0acrx4XtPRmUNaZ01lEMWvUYibr3DFnAlC2iQowVY+yck 1miw==
X-Gm-Message-State	ALoCoQlYGU34iBDLGMzIgXpgTOr3qh5vJXwYbFLmavkL2yku3sry1vMwA9u1HVS3AAsN9t/EWynXL5lzCnhqbM0bf3bSQH/SMAJoqa39SppvJLYzsE93JGClV8vj/6qeKrrCMKw/ol5m1lpzT0TrQF23Lo5f9jBfMhivQQ36HcNm6ItYBU4+CZPF1CL0ItrUv08Y7l2HNDpR
X-Received	by 10.55.80.197 with SMTP id e188mr63761695qkb.10.1451208477947; Sun, 27 Dec 2015 01:27:57 -0800 (PST)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Date	Sun, 27 Dec 2015 04:27:54 -0500
X-Original-Message-ID	<567FAF1A.7030200@earth2me.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1298335

Show key headers only | View raw

26bff5f099722fa7c38796a3ccd0e880cf1a524a introduced a regression in 
ideapad_laptop (https://bugzilla.kernel.org/show_bug.cgi?id=110021).  
I've created a quick fix as a pull request: 
https://github.com/torvalds/linux/pull/236  Here's the patch, for 
convenience:

*** drivers/platform/x86/ideapad-laptop.c.old    2015-12-27 
03:48:36.243613843 -0500
--- drivers/platform/x86/ideapad-laptop.c    2015-12-27 
03:49:28.310280733 -0500
*************** static int ideapad_acpi_add(struct platf
*** 933,939 ****
       ideapad_sync_rfk_state(priv);
       ideapad_sync_touchpad_state(priv);

!     if (acpi_video_get_backlight_type() == acpi_backlight_vendor) {
           ret = ideapad_backlight_init(priv);
           if (ret && ret != -ENODEV)
               goto backlight_failed;
--- 933,939 ----
       ideapad_sync_rfk_state(priv);
       ideapad_sync_touchpad_state(priv);

!     if (acpi_video_get_backlight_type() != acpi_backlight_vendor) {
           ret = ideapad_backlight_init(priv);
           if (ret && ret != -ENODEV)
               goto backlight_failed;

I've tested the patch on a Yoga 900 running 4.3.3 x86_64 with a few 
other compatibility patches.  Backlight controls work perfectly with it 
applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

ideapad_laptop: Fix for backlight regression Paul Buonopane <paul@earth2me.com> - 2015-12-27 10:30 +0100

csiph-web