Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298322

[PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE()

Show all headers | View raw

running sparse on drivers/staging/lustre results in dozens of warnings:
include/linux/gfp.h:281:41: warning:
odd constant _Bool cast (400000 becomes 1)

Use "!!" to explicitly convert the result to bool range.
---
 include/linux/gfp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 91f74e7..6e58a8f 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -278,7 +278,7 @@ static inline int gfpflags_to_migratetype(const gfp_t gfp_flags)
 
 static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)
 {
-	return (bool __force)(gfp_flags & __GFP_DIRECT_RECLAIM);
+	return (bool __force)!!(gfp_flags & __GFP_DIRECT_RECLAIM);
 }
 
 #ifdef CONFIG_HIGHMEM
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE() Joshua Clayton <stillcompiling@gmail.com> - 2015-12-27 06:20 +0100
  Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE() Al Viro <viro@ZenIV.linux.org.uk> - 2015-12-27 06:50 +0100
    [PATCH v2] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE() Joshua Clayton <stillcompiling@gmail.com> - 2015-12-27 07:50 +0100
  Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE() Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-30 05:50 +0100
    Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE() Joshua Clayton <stillcompiling@gmail.com> - 2015-12-30 06:00 +0100

csiph-web