Re: [PATCH] Input: evdev: avoid storing newest SYN_REPORT when dropping all events

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: evdev: avoid storing newest SYN_REPORT when dropping all events
Date	Tue, 29 Dec 2015 00:50:01 +0100
Message-ID	<qKPI5-Ek-5@gated-at.bofh.it> (permalink)
References	<qJjKh-2gc-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2Km5eHu0FTSmcwA75NGD7/UGjaBMjthQ7GRnCBnWPqs=; b=QCOiY97GVDYll60iOQwHRVLyM11VbTf2QoBq+J48pUnc+yn4lYKe0mCefKrySi4JfL HZX8RFVvevDlIv8s5Gmi1TJ7F2OHTKp4zDQStuR+9mxRllakl1hBX+eQo1c4/WtsRP1w oSTV33ythgwn+wNd+8CvGdZ+OpxNuzJwIuf8ygJwjooJJXbP/yOXbYbBfxeZ5kcZw4De HT1P25ltRv3frSpStaA9mFL7GuiCAez4z0ztuPzzELAMn7Aaxt2/eIgTpph+E6/PIy7M HsjmGvMlcx1onClJ68nqUovsPtIt3ymaao6rZ7kz6s7mHrIpcXHkxFez455ExEejTc6X bIpg==
MIME-Version	1.0
X-Received	by 10.202.200.79 with SMTP id y76mr28419824oif.111.1451346085689; Mon, 28 Dec 2015 15:41:25 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Aniroop Mathur <aniroop.mathur@gmail.com>
X-Original-Date	Mon, 28 Dec 2015 15:41:25 -0800
X-Original-Message-ID	<CAKdAkRR0aiziybrsDnvNwC7qCY7vg3K4UHaWfwkZ9oX7hguQOQ@mail.gmail.com>
X-Original-References	<1450985148-804-1-git-send-email-a.mathur@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1298799

Show key headers only | View raw

Hi Aniroop,

On Thu, Dec 24, 2015 at 11:25 AM, Aniroop Mathur <a.mathur@samsung.com> wrote:
> The newest event can be SYN_REPORT in case of dropping all old events when
> buffer is full, but as now there is no device data available to read so
> lets drop SYN_REPORT as well and store only SYN_DROPPED.
>

We can not drop the SYN_REPORT event in this case as userspace needs
it to determine if the events that are coming after SYN_DROPPED are
part of a full packet or if they belong to a partial packet. From
Documentation/input/event-codes.txt:

* SYN_DROPPED:
  - Used to indicate buffer overrun in the evdev client's event queue.
    Client should ignore all events up to and including next SYN_REPORT
    event and query the device (using EVIOCG* ioctls) to obtain its
    current state.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] Input: evdev: avoid storing newest SYN_REPORT when dropping all events Aniroop Mathur <a.mathur@samsung.com> - 2015-12-24 20:30 +0100
  Re: [PATCH] Input: evdev: avoid storing newest SYN_REPORT when  dropping all events Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-29 00:50 +0100
    Re: [PATCH] Input: evdev: avoid storing newest SYN_REPORT when  dropping all events Aniroop Mathur <aniroop.mathur@gmail.com> - 2015-12-29 19:10 +0100

csiph-web