Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298788

Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock

Show all headers | View raw

On Sun, 27 Dec 2015 17:34:25 -0800
Bjorn Andersson <bjorn@kryo.se> wrote:

> In preparation for handling incoming messages from IRQ context, change
> the indication list lock to a spinlock
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
>  drivers/net/wireless/ath/wcn36xx/smd.c     | 12 ++++++------
>  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |  2 +-
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 6b5dbe6f0d0a..4307429740a9 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -2165,10 +2165,10 @@ static void wcn36xx_smd_rsp_process(struct wcn36xx *wcn, void *buf, size_t len)
>  		msg_ind->msg_len = len;
>  		memcpy(msg_ind->msg, buf, len);
>  
> -		mutex_lock(&wcn->hal_ind_mutex);
> +		spin_lock(&wcn->hal_ind_lock);

If you are going to handle messages in IRQ context, that better be a spin_lock_irq() or spin_lock_bh().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] WCN36xx convert to mainline SMD interface Bjorn Andersson <bjorn@kryo.se> - 2015-12-28 03:50 +0100
  [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Bjorn Andersson <bjorn@kryo.se> - 2015-12-28 03:50 +0100
    Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Rob Herring <robh@kernel.org> - 2015-12-29 19:40 +0100
      Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Bjorn Andersson <bjorn@kryo.se> - 2015-12-29 20:10 +0100
        Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Rob Herring <robh@kernel.org> - 2015-12-30 00:30 +0100
    Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Andy Gross <andy.gross@linaro.org> - 2015-12-29 20:20 +0100
  [PATCH 2/4] wcn36xx: Change indication list lock to spinlock Bjorn Andersson <bjorn@kryo.se> - 2015-12-28 03:50 +0100
    Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock Stephen Hemminger <stephen@networkplumber.org> - 2015-12-29 00:10 +0100
      Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock Bjorn Andersson <bjorn@kryo.se> - 2015-12-29 05:30 +0100
  [PATCH 3/4] wcn36xx: Transition driver to SMD client Bjorn Andersson <bjorn@kryo.se> - 2015-12-28 03:50 +0100
  [PATCH 1/4] wcn36xx: Fold indication payload into message header Bjorn Andersson <bjorn@kryo.se> - 2015-12-28 03:50 +0100

csiph-web