Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298779

Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision"

Show all headers | View raw

On Monday 28 December 2015 13:01:22 Frank Rowand wrote:
> 
> Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revision"
> property.
> 
> If the use of /revision is limited to being a location to hold an ATAG
> value to pass to the global variable system_rev, then it would make
> sense to just copy directly from the ATAG value into system_rev in the
> same board file where you are copying the ATAGs.

Agreed. That would be simpler, and avoid a situation where someone relies
on the /revision property in DT to be set from the atags compat code
(preventing an upgrade to a newer bootloader), or on the system_rev variable
to be the same across multiple boot loaders, in the absence of other
kernel code setting it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Pali Rohár <pali.rohar@gmail.com> - 2015-12-24 20:10 +0100
  Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Frank Rowand <frowand.list@gmail.com> - 2015-12-28 22:10 +0100
    Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Arnd Bergmann <arnd@arndb.de> - 2015-12-28 23:30 +0100

csiph-web