Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber()

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber()
Date	2015-12-28 20:10 +0100
Message-ID	<qKLl8-6kY-17@gated-at.bofh.it> (permalink)
References	<qKKyK-5LQ-3@gated-at.bofh.it> <qKKIq-5Qe-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 28, 2015 at 8:25 PM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2015-12-28 at 20:18 +0200, Andy Shevchenko wrote:
>> xnumber() is a special helper to print a fixed size type in a hex format with
>> '0x' prefix with padding and reduced size. In the module we have already
>> several copies of such code. Consolidate them under xnumber() helper.
>>
>> There are couple of differences though.
>>
>> It seems nobody cared about the output in case of CONFIG_KALLSYMS=n when
>> printing symbol address because the asked width is not enough to care either
>> prefix or last byte. Fixed here.
>>
>> The %pNF specifier used to be allowed with a specific field width, though there
>> is neither any user of it nor mention in the documentation.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>  lib/vsprintf.c | 43 +++++++++++++++----------------------------
>>  1 file changed, 15 insertions(+), 28 deletions(-)
>>
>> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
>> index dcf5646..e971549 100644
>> --- a/lib/vsprintf.c
>> +++ b/lib/vsprintf.c
>> @@ -514,6 +514,16 @@ char *number(char *buf, char *end, unsigned long long num,
>>       return buf;
>>  }
>>
>> +static noinline_for_stack
>> +char *xnumber(char *buf, char *end, unsigned long long value, unsigned int type,
>> +           struct printf_spec spec)
>
> xnumber isn't a great name.

I rather agree, however had nothing yet to replace. Any ideas?

> unsigned int type should probably be size_t size

Used to be :-), though I decided to move it to unsigned int since the
resulting field is anyway 8 bits of unsigned int.
If you think it's better to do all conversion inside xnumber (or
whatever name it would be), I redo this.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-28 19:20 +0100
  Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to  xnumber() Joe Perches <joe@perches.com> - 2015-12-28 19:30 +0100
    Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-28 20:10 +0100
      Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to  xnumber() Joe Perches <joe@perches.com> - 2015-12-29 01:20 +0100
    Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-28 22:50 +0100
      Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-28 23:30 +0100
        Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-29 00:10 +0100
        Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to  xnumber() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-29 16:10 +0100
      Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-28 23:30 +0100
      Re: [PATCH v1 1/1] lib/vsprintf: refactor duplicate code to xnumber() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-28 23:30 +0100

csiph-web