Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver

From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver
Date	2015-12-28 11:40 +0100
Message-ID	<qKDnA-AY-13@gated-at.bofh.it> (permalink)
References	<qKkXE-8kO-5@gated-at.bofh.it> <qKkXE-8kO-3@gated-at.bofh.it> <qKw3k-3Io-763@gated-at.bofh.it> <qKBYt-8fe-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 28 December 2015 02:30 PM, Daniel Lezcano wrote:
>>> reproduce:
>>>        # save the attached .config to linux build tree
>>>       make ARCH=i386
>>
>> This is meant for ARC only (not i386), I will add to the Kconfig file a
>> dependency on my platform.
> 
> Hi Noam,
> 
> for compilation test coverage it would be nice to not restrict the to ARC only but
> change the write_aux_reg to a common name across the different arch if possible.
> 
>   -- Daniel

Hi Daniel,

AUX registers is a ARC specific mechanism used to access some of the core
functionality (intc, caches, ....) which other arches likely do via MMIO. I don't
think a generic abstraction exists. And IMHO it doesn't make sense to invent one
given this may not map directly to other arches.

This was one of the key reasons arc intc/timers were not added to drivers/* in
first place.

I do agree with compilation test coverage aspect though.
Maybe we add a *hack* to include/soc/nps/common.h

#ifndef __ARC__
#define  write_aux_reg(r, v)
#define  read_aux_reg(r) 0
#endif

What say you ?

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver Noam Camus <noamc@ezchip.com> - 2015-12-28 03:50 +0100
  Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-12-28 10:10 +0100
    Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-28 11:40 +0100
      Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-12-28 12:00 +0100
        Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-28 12:20 +0100

csiph-web