[PATCH 1/2] ipc/mqueue: remove assignment from IS_ERR argument

From	Julia Lawall <Julia.Lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] ipc/mqueue: remove assignment from IS_ERR argument
Date	2015-12-26 23:20 +0100
Message-ID	<qK5lU-6Is-1@gated-at.bofh.it> (permalink)
References	<qK5lU-6Is-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2;
statement S1,S2;
@@

+e1 = e2;
if (IS_ERR(
    e1
-   = e2
   )) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 ipc/mqueue.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index f4617cf..3975abc 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -786,7 +786,8 @@ SYSCALL_DEFINE4(mq_open, const char __user *, u_name, int, oflag, umode_t, mode,
 
 	audit_mq_open(oflag, mode, u_attr ? &attr : NULL);
 
-	if (IS_ERR(name = getname(u_name)))
+	name = getname(u_name);
+	if (IS_ERR(name))
 		return PTR_ERR(name);
 
 	fd = get_unused_fd_flags(O_CLOEXEC);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/2] ipc/mqueue: remove assignment from IS_ERR argument Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-26 23:20 +0100

csiph-web