Re: [PATCH 6/7] drivers: net: cpsw: fix error return code

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/7] drivers: net: cpsw: fix error return code
Date	2015-12-26 19:00 +0100
Message-ID	<qK1ih-3Yh-1@gated-at.bofh.it> (permalink)
References	<qJZgt-2JU-5@gated-at.bofh.it> <qJZgt-2JU-17@gated-at.bofh.it> <qK0YW-3PM-5@gated-at.bofh.it> <qK18C-3TX-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/26/2015 8:40 PM, Julia Lawall wrote:

>>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>>> b/drivers/net/ethernet/ti/cpsw.c
>>> index 3409e80..6a76992 100644
>>> --- a/drivers/net/ethernet/ti/cpsw.c
>>> +++ b/drivers/net/ethernet/ti/cpsw.c
>>> @@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev)
>>>
>>>    	/* RX IRQ */
>>>    	irq = platform_get_irq(pdev, 1);
>>> -	if (irq < 0)
>>> +	if (irq < 0) {
>>> +		ret = -ENOENT;
>>
>>     Why not just propagate an error returned by that function?
>
> OK, I did what was done a few lines before in the same function:
>
>          ndev->irq = platform_get_irq(pdev, 1);
>          if (ndev->irq < 0) {
> 		dev_err(priv->dev, "error getting irq resource\n");
>                  ret = -ENOENT;
>                  goto clean_ale_ret;
>          }
>
> Maybe they should all be changed?

    Yeah, I'd vote for it. I'm seeing no sense in overriding an actual error.

[...]

> julia

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/7] fix error return code Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-26 16:50 +0100
  [PATCH 6/7] drivers: net: cpsw: fix error return code Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-26 16:50 +0100
    Re: [PATCH 6/7] drivers: net: cpsw: fix error return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 18:40 +0100
      Re: [PATCH 6/7] drivers: net: cpsw: fix error return code Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 18:50 +0100
        Re: [PATCH 6/7] drivers: net: cpsw: fix error return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 19:00 +0100
          [PATCH 6/7 v2] drivers: net: cpsw: fix error return code Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 20:20 +0100
          Re: [PATCH 6/7] drivers: net: cpsw: fix error return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 21:00 +0100
            Re: [PATCH 6/7] drivers: net: cpsw: fix error return code Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:10 +0100
              Re: [PATCH 6/7] drivers: net: cpsw: fix error return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 21:20 +0100

csiph-web