Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

From	Paul Kocialkowski <contact@paulk.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features
Date	2015-12-24 20:40 +0100
Message-ID	<qJjTY-2jq-9@gated-at.bofh.it> (permalink)
References	<qIPsR-oU-3@gated-at.bofh.it> <qIPsS-oU-5@gated-at.bofh.it> <qIU9b-3q8-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Le mercredi 23 décembre 2015 à 13:03 -0300, Javier Martinez Canillas a
écrit :
> Hello Paul,
> 
> [snip]
> 
> > +
> > +&omap3_pmx_core {
> > +       pinctrl-names = "default";
> > +
> > +       uart3_pins: pinmux_uart3_pins {
> > +               pinctrl-single,pins = <
> > +                       0x16e (PIN_INPUT | MUX_MODE0)           /* uart3_rx_irrx */
> > +                       0x170 (PIN_OUTPUT | MUX_MODE0)          /* uart3_tx_irtx */
> > +               >;
> 
> Could you please use the IOPAD mux macros from
> include/dt-bindings/pinctrl/omap.h instead?
> 
> We just did a massive cleanup on the OMAP DTS to use them instead of
> an offset from the padconf registers.

Sure thing, will do in v2.

Thanks for the review!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
  Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper  support, with basic features Tony Lindgren <tony@atomide.com> - 2015-12-23 16:50 +0100
    Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper  support, with basic features Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 20:40 +0100
  Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support,  with basic features Javier Martinez Canillas <javier@dowhile0.org> - 2015-12-23 17:10 +0100
    Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper  support, with basic features Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 20:40 +0100

csiph-web