Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297899

Re: [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

Show all headers | View raw

On 12/24/2015 07:07 AM, Damien Riegel wrote:
> On Wed, Dec 23, 2015 at 09:11:28PM -0800, Guenter Roeck wrote:
>> The 'dev' variable in watchdog drivers has a different lifetime than the
>> watchdog character device and should therefore not be used by watchdog
>> drivers.
>>
>> Some of the drivers use the variable to print kernel messages. Those are
>> either dropped or converted to use pr_ functions. One driver sets the
>> variable during initialization to the watchdog driver's parent device,
>> which is wrong and also removed.
>
> Hi Guenter,
>
> For gpio_wdt and mena21_wdt, wdd->parent is set and could be used for
> dev_* printings. Do you prefer to keep this variable only for watchdog
> core internal usage? Otherwise, the serie looks good.
>
Good idea, I'll use ->parent for those. ->parent is set by the driver,
so it is safe to be used by the driver.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Guenter Roeck <linux@roeck-us.net> - 2015-12-24 06:20 +0100
  [PATCH 1/5] watchdog: bcm2835_wdt: Drop log message if watchdog is stopped Guenter Roeck <linux@roeck-us.net> - 2015-12-24 06:20 +0100
  [PATCH 2/5] watchdog: tangox: Print info message using pointer to platform device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 06:20 +0100
  [PATCH 5/5] watchdog: qcom-wdt: Do not set 'dev' in struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 06:20 +0100
  [PATCH 3/5] watchdog: gpio: Do not use device pointer from struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 06:20 +0100
  [PATCH 4/5] watchdog: mena21: Do not use device pointer from struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 06:20 +0100
  Re: [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in  watchdog drivers Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-24 16:10 +0100
    Re: [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in  watchdog drivers Guenter Roeck <linux@roeck-us.net> - 2015-12-24 16:30 +0100

csiph-web