Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x
Date	2015-12-24 12:10 +0100
Message-ID	<qJbWq-5Z3-7@gated-at.bofh.it> (permalink)
References	<qG1TA-7mv-33@gated-at.bofh.it> <qG1TA-7mv-31@gated-at.bofh.it> <qHD0K-3Ju-15@gated-at.bofh.it> <qHL7X-si-7@gated-at.bofh.it> <qIzHs-7mN-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote :
> Well, the binding should reflect that, whether the driver needs to be
> re-written is somewhat a separate question. That should probably have
> been done for the DS1302 driver originally and it is not too fair for
> the 2nd person to fix it. You could just have a single driver bound to
> the controller node which is aware of the DS1302 being the slave
> device (ignoring that part of the DT for now).
> 

I agree with Rob here. I won't require that you fix the driver but it
would be better to have a proper DT binding from the beginning so that
when the driver is fixed it will still work with the previous device
trees.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Sergei Ianovich <ynvich@gmail.com> - 2015-12-15 18:50 +0100
  Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Rob Herring <robh@kernel.org> - 2015-12-20 04:40 +0100
    Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Sergei Ianovich <ynvich@gmail.com> - 2015-12-20 13:20 +0100
      Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Rob Herring <robh@kernel.org> - 2015-12-22 19:20 +0100
        Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Sergei Ianovich <ynvich@gmail.com> - 2015-12-24 12:10 +0100
        Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-24 12:10 +0100

csiph-web