Re: [PATCH] gpiolib: Fix uninitialized variable warning

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpiolib: Fix uninitialized variable warning
Date	2015-12-24 10:10 +0100
Message-ID	<qJa4i-4Qs-3@gated-at.bofh.it> (permalink)
References	<qIZsd-6sP-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 23, 2015 at 10:46 PM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:

> Commit ef7c7553039b ("gpiolib: improve overlap check of range of gpio")
> introduced the following compiler warning:
>
> drivers/gpio/gpiolib.c: In function ‘gpiochip_add’:
> drivers/gpio/gpiolib.c:193:20: warning: ‘iterator’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   struct gpio_chip *iterator;
>                     ^
>
> Fix this by initializing 'iterator' to NULL.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
>
> This was found in next-20151223.

Several people reported this and I was waiting for a proper
fix from Bamvor (as it is a false compile warning and doesn't
really indicate a real error) but now I'll apply this to
get rid of all the reports and patches filling my mailbox...

Merry Christmas!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpiolib: Fix uninitialized variable warning Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-12-23 22:50 +0100
  Re: [PATCH] gpiolib: Fix uninitialized variable warning Bjorn Andersson <bjorn@kryo.se> - 2015-12-24 09:20 +0100
  Re: [PATCH] gpiolib: Fix uninitialized variable warning Linus Walleij <linus.walleij@linaro.org> - 2015-12-24 10:10 +0100

csiph-web