Re: [PATCH v3] um: Fix build error and kconfig for i386

From	Josh Triplett <josh@joshtriplett.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] um: Fix build error and kconfig for i386
Date	2015-12-26 05:20 +0100
Message-ID	<qJOuJ-4xy-1@gated-at.bofh.it> (permalink)
References	<qJd2a-6AH-9@gated-at.bofh.it> <qJpwl-5D5-1@gated-at.bofh.it> <qJGdP-7Ap-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 25, 2015 at 07:45:41PM +0100, Mickaël Salaün wrote:
> 
> On 25/12/2015 02:34, Josh Triplett wrote:
> > On Thu, Dec 24, 2015 at 01:12:11PM +0100, Mickaël Salaün wrote:
> >> Fix build error by generating elfcore.o only when ELF_CORE (depending on
> >> COREDUMP) is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> >> Cc: Jeff Dike <jdike@addtoit.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Josh Triplett <josh@joshtriplett.org>
> >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >> Cc: Michal Marek <mmarek@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > 
> > It looks like ELF_CORE depends on COREDUMP, but not on BINFMT_ELF.
> > Should it?  What happens if you build this with ELF_CORE=y and
> > BINFMT_ELF=n?  Does that configuration even make sense?
> 
> It build fine with ELF_CORE=y and BINFMT_ELF=n but does not seem
> useful. Nevertheless, it's the same for all architectures (cf.
> init/Kconfig): ELF_CORE only depends on COREDUMP.

As long as that builds, then this patch doesn't introduce an
un-buildable Kconfig configuration, so it seems reasonable.  Thanks
again for producing a new version.

Reviewed-by: Josh Triplett <josh@joshtriplett.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] um: Fix build error and kconfig for i386 Mickaël Salaün <mic@digikod.net> - 2015-12-24 13:20 +0100
  Re: [PATCH v3] um: Fix build error and kconfig for i386 Josh Triplett <josh@joshtriplett.org> - 2015-12-25 02:40 +0100
    Re: [PATCH v3] um: Fix build error and kconfig for i386 Mickaël Salaün <mic@digikod.net> - 2015-12-25 20:30 +0100
      Re: [PATCH v3] um: Fix build error and kconfig for i386 Josh Triplett <josh@joshtriplett.org> - 2015-12-26 05:20 +0100

csiph-web