Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298159

[PATCH] usb: gadget: acm: set notify_req to NULL after freed to avoid double free

Show all headers | View raw

From: "Du, Changbin" <changbin.du@intel.com>

If acm_bind fails before allocate notification and acm->notify_req is
not set to NULL after freed last time, double free will happen.

kernel BUG at mm/slub.c:3392!
invalid opcode: 0000 [#1] PREEMPT SMP
EIP is at kfree+0x172/0x180
Call Trace:
[<80c0e3b6>] ? usb_ep_autoconfig_ss+0x86/0x170
[<80c13345>] gs_free_req+0x15/0x30
[<80c12df1>] acm_bind+0x1c1/0x2d0
[<80c0e9be>] usb_add_function+0x6e/0x120
[<80c213cb>] acm_function_bind_config+0x2b/0x90

Signed-off-by: Du, Changbin <changbin.du@intel.com>
---
 drivers/usb/gadget/function/f_acm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/function/f_acm.c b/drivers/usb/gadget/function/f_acm.c
index 2fa1e80..e10c8d4 100644
--- a/drivers/usb/gadget/function/f_acm.c
+++ b/drivers/usb/gadget/function/f_acm.c
@@ -699,8 +699,10 @@ acm_bind(struct usb_configuration *c, struct usb_function *f)
 	return 0;
 
 fail:
-	if (acm->notify_req)
+	if (acm->notify_req) {
 		gs_free_req(acm->notify, acm->notify_req);
+		acm->notify_req = NULL;
+	}
 
 	ERROR(cdev, "%s/%p: can't bind, err %d\n", f->name, f, status);
 
@@ -713,8 +715,10 @@ static void acm_unbind(struct usb_configuration *c, struct usb_function *f)
 
 	acm_string_defs[0].id = 0;
 	usb_free_all_descriptors(f);
-	if (acm->notify_req)
+	if (acm->notify_req) {
 		gs_free_req(acm->notify, acm->notify_req);
+		acm->notify_req = NULL;
+	}
 }
 
 static void acm_free_func(struct usb_function *f)
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: acm: set notify_req to NULL after freed to avoid double free changbin.du@intel.com - 2015-12-26 05:10 +0100
  Re: [PATCH] usb: gadget: acm: set notify_req to NULL after freed to  avoid double free Robert Baldyga <r.baldyga@hackerion.com> - 2015-12-28 03:50 +0100
    RE: [PATCH] usb: gadget: acm: set notify_req to NULL after freed to  avoid double free "Du, Changbin" <changbin.du@intel.com> - 2015-12-28 07:10 +0100
      [PATCH v2] usb: gadget: fix double mem free for usb_request caused by wild pointers changbin.du@intel.com - 2015-12-28 07:40 +0100
        Re: [PATCH v2] usb: gadget: fix double mem free for usb_request caused by wild pointers Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-12-28 22:20 +0100
        Re: [PATCH v2] usb: gadget: fix double mem free for usb_request  caused by wild pointers Robert Baldyga <r.baldyga@hackerion.com> - 2015-12-28 23:10 +0100

csiph-web