Re: [PATCH v2] um: Fix build error and kconfig for i386

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] um: Fix build error and kconfig for i386
Date	2015-12-25 16:20 +0100
Message-ID	<qJCjT-5a7-1@gated-at.bofh.it> (permalink)
References	<qIRbk-1fn-21@gated-at.bofh.it> <qIZse-6sP-19@gated-at.bofh.it> <qJd2a-6AH-11@gated-at.bofh.it> <qJpmG-5Aj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 25.12.2015 um 02:26 schrieb Josh Triplett:
> On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote:
>>
>> On 23/12/2015 22:42, Josh Triplett wrote:
>>> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
>>>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>>>
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>>>> (.text+0x3e62): undefined reference to `dump_emit'
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>>>> (.text+0x3eef): undefined reference to `dump_emit'
>>>>
>>>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>>>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>>>> Cc: Jeff Dike <jdike@addtoit.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Josh Triplett <josh@joshtriplett.org>
>>>> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>>> Cc: Michal Marek <mmarek@suse.cz>
>>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>>>
>>> I suppose um doesn't care deeply about binary size, but ideally I would
>>> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
>>> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>>
>> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
> 
> -mm regularly replaces patches with newer versions, so that ought to be
> fine.

Usually non-trivial UML stuff goes thought me.
As Josh noted, just post an updated version of the patch.
Either me or Andrew will pick it up.

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] um: Fix build error and kconfig for i386 Mickaël Salaün <mic@digikod.net> - 2015-12-23 14:00 +0100
  Re: [PATCH v2] um: Fix build error and kconfig for i386 Josh Triplett <josh@joshtriplett.org> - 2015-12-23 22:50 +0100
    Re: [PATCH v2] um: Fix build error and kconfig for i386 Mickaël Salaün <mic@digikod.net> - 2015-12-24 13:20 +0100
      Re: [PATCH v2] um: Fix build error and kconfig for i386 Josh Triplett <josh@joshtriplett.org> - 2015-12-25 02:30 +0100
        Re: [PATCH v2] um: Fix build error and kconfig for i386 Richard Weinberger <richard@nod.at> - 2015-12-25 16:20 +0100

csiph-web