Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA
Date	2015-12-24 01:20 +0100
Message-ID	<qJ1Nn-87c-5@gated-at.bofh.it> (permalink)
References	<qBmci-3CV-9@gated-at.bofh.it> <qIXJL-5o9-1@gated-at.bofh.it> <qIYmu-5Qe-3@gated-at.bofh.it> <qIZ8T-6mo-31@gated-at.bofh.it> <qIZsd-6sP-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Nicolas Pitre <nicolas.pitre@linaro.org> [151223 13:45]:
> On Wed, 23 Dec 2015, Tony Lindgren wrote:
> 
> > Hi,
> > 
> > * Laura Abbott <labbott@redhat.com> [151223 12:31]:
> > > 
> > > Looks like a case similar to Geert's
> > > 
> > >         adr     r7, kick_counter
> > > wait_dll_lock_timed:
> > >         ldr     r4, wait_dll_lock_counter
> > >         add     r4, r4, #1
> > >         str     r4, [r7, #wait_dll_lock_counter - kick_counter]
> > >         ldr     r4, sdrc_dlla_status
> > >         /* Wait 20uS for lock */
> > >         mov     r6, #8
> > > 
> > > 
> > > kick_counter and wait_dll_lock_counter are in the text section which is marked read only.
> > > They need to be moved to the data section along with a few other variables from what I
> > > can tell (maybe those are read only?).
> > 
> > Thanks for looking, yeah so it seem.
> > 
> > > I suspect this is going to be a common issue with suspend/resume code paths since those
> > > are hand written assembly.
> > 
> > Yes I suspect we have quite a few cases like this.
> 
> We fixed a bunch of similar issues where code was located in the .data 
> section for ease of use from assembly code.  See commit b4e61537 and 
> d0776aff for example.

Thanks hey some assembly fun for the holidays :) I also need to check what
all gets relocated to SRAM here.

In any case, seems like the $subject patch is too intrusive for v4.5 at
this point.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Tony Lindgren <tony@atomide.com> - 2015-12-23 21:00 +0100
  Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-23 21:10 +0100
    Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Tony Lindgren <tony@atomide.com> - 2015-12-23 21:20 +0100
  Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Laura Abbott <labbott@redhat.com> - 2015-12-23 21:40 +0100
    Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Tony Lindgren <tony@atomide.com> - 2015-12-23 22:30 +0100
      Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-12-23 22:50 +0100
        Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Tony Lindgren <tony@atomide.com> - 2015-12-24 01:20 +0100
          Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-24 01:40 +0100

csiph-web