Re: [PATCH 1/2] drivers/pci: make host/pcie-rcar.c explicitly non-modular

From	Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] drivers/pci: make host/pcie-rcar.c explicitly non-modular
Date	2015-12-22 17:30 +0100
Message-ID	<qIxZ1-6go-45@gated-at.bofh.it> (permalink)
References	<qIjsZ-5iB-9@gated-at.bofh.it> <qIjsZ-5iB-7@gated-at.bofh.it> <qIqEa-1y3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-12-22 03:30 AM, Geert Uytterhoeven wrote:
> Hi Paul,
> 
> On Tue, Dec 22, 2015 at 1:59 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> We also delete the MODULE_LICENSE tag etc. since all that information
>> was (or is now) contained at the top of the file in the comments.
> 
> The MODULE_* tags are easier to parse by automated tools.
> Do we want to make the work of e.g. the SPDX people harder?

As JoeP pointed out, the AUTHOR tags are routinely out of date
and not used by get_maintainer.pl by default, and I've found a
lot of LICENCE tags that say GPL while the text at the top says
GPLv2.  On top of that, they are not present all the time since
proper non-modular drivers don't have them.  So, no I have no
problems whatsoever in removing them from non-modular code.

If you want to make the case for tags that are module/non-module
agnostic, and you think there is genuine value in it and you can
get buy in on that, then feel free.

Paul.
--

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drivers/pci: make host/pcie-rcar.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-22 02:00 +0100
  Re: [PATCH 1/2] drivers/pci: make host/pcie-rcar.c explicitly non-modular Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-22 09:40 +0100
    Re: [PATCH 1/2] drivers/pci: make host/pcie-rcar.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-22 17:30 +0100

csiph-web